scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json - Issue 1862223004: Add disable_brotli_filter and use_platform_icu_alternatives to cronet builder config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json

Issue 1862223004: Add disable_brotli_filter and use_platform_icu_alternatives to cronet builder config. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/cronet/example.expected/local_test.json ('k') | scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json

diff --git a/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json b/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json

index f6ed358f9250596d9164869827622f8c7f5dc4e1..b53ec21316f0d5c481f124e555467f32c5fa9581 100644

--- a/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json

+++ b/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json

@@ -160,7 +160,7 @@

"env": {

"GYP_CHROMIUM_NO_ACTION": "1",

jbudorick 2016/04/07 21:00:40 I imagine you realize this, but just to make sure

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "OS=android component=static_library disable_file_support=1 disable_ftp_support=1 enable_bidirectional_stream=1 enable_websockets=0 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm64 use_goma=1",

+ "GYP_DEFINES": "OS=android component=static_library disable_brotli_filter=1 disable_file_support=1 disable_ftp_support=1 enable_bidirectional_stream=1 enable_websockets=0 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm64 use_goma=1 use_platform_icu_alternatives=1",

"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

"name": "gclient runhooks"