Roll third_party/polymer.

Roll third_party/polymer.

- Added new carbon-route element.
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.

NOPRESUBMIT=true  # crisper.js

Committed: https://crrev.com/f63998d6e41aebef66673ff0e837165488ee6bc5
Cr-Commit-Position: refs/heads/master@{#387633}

[dpapad, 2016-04-06 19:30:39]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-04-06 19:30:41]

@Michael: This roll is fixing crbug.com/600887, but it is introducing a
different bug (also related to neon-animated-pages). You can reproduce by
navigating directly to chrome://md-settings/searchEngines, where you will see
the whole page flash (fade-in, fade-out, fade-in again).

[dpapad, 2016-04-06 19:34:21]

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#~1.1.2",
Lines 64-65 should probably use "#^a.b.c" instead of "#~a.b.c", right? Just
noticed this.

[michaelpg, 2016-04-06 21:35:16]

On 2016/04/06 19:30:41, dpapad wrote:
> @Michael: This roll is fixing crbug.com/600887, but it is introducing a
> different bug (also related to neon-animated-pages). You can reproduce by
> navigating directly to chrome://md-settings/searchEngines, where you will see
> the whole page flash (fade-in, fade-out, fade-in again).

looking

[Dan Beam, 2016-04-06 22:00:30]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-04-06 22:00:31]

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#~1.1.2",
On 2016/04/06 19:34:21, dpapad wrote:
> Lines 64-65 should probably use "#^a.b.c" instead of "#~a.b.c", right? Just
> noticed this.

assuming you already saw this, but: https://github.com/npm/node-semver

[Dan Beam, 2016-04-06 22:00:45]

Description was changed from

==========
Roll third_party/polymer.

BUG=600887
==========

to

==========
Roll third_party/polymer.

BUG=600887
==========

[Dan Beam, 2016-04-06 22:00:45]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[michaelpg, 2016-04-06 22:14:58]

On 2016/04/06 19:30:41, dpapad wrote:
> @Michael: This roll is fixing crbug.com/600887, but it is introducing a
> different bug (also related to neon-animated-pages). You can reproduce by
> navigating directly to chrome://md-settings/searchEngines, where you will see
> the whole page flash (fade-in, fade-out, fade-in again).

https://jsfiddle.net/mgiuffrida/fy7btc7p/

i'll file a bug

[michaelpg, 2016-04-06 22:19:28]

On 2016/04/06 22:14:58, michaelpg wrote:
> On 2016/04/06 19:30:41, dpapad wrote:
> > @Michael: This roll is fixing crbug.com/600887, but it is introducing a
> > different bug (also related to neon-animated-pages). You can reproduce by
> > navigating directly to chrome://md-settings/searchEngines, where you will
see
> > the whole page flash (fade-in, fade-out, fade-in again).
> 
> https://jsfiddle.net/mgiuffrida/fy7btc7p/
> 
> i'll file a bug

bug already exists: https://github.com/PolymerElements/neon-animation/issues/146

i'll ping cdata@

[dpapad, 2016-04-06 22:20:00]

On 2016/04/06 at 22:14:58, michaelpg wrote:
> On 2016/04/06 19:30:41, dpapad wrote:
> > @Michael: This roll is fixing crbug.com/600887, but it is introducing a
> > different bug (also related to neon-animated-pages). You can reproduce by
> > navigating directly to chrome://md-settings/searchEngines, where you will
see
> > the whole page flash (fade-in, fade-out, fade-in again).
> 
> https://jsfiddle.net/mgiuffrida/fy7btc7p/
> 
> i'll file a bug

Thanks for figuring out a minimal repro case. In the meantime there are still
test errors and compile errors to be resolved, so this CL is not ready.

[dpapad, 2016-04-07 00:43:47]

+tommycli

Status update:
There four issues discovered so far blocking this Polymer roll.

1) Test failure FindInPageControllerTest.SearchWithinSpecialURL (dbeam@ is
investigating, thanks).
2) neon-animated-pages flash. There is a candidate PR
https://github.com/PolymerElements/neon-animation/pull/149, but michaelpg@ and I
thought that there might be a better fix than listening for iron-select.
michaelpg@ will try to contact cdata@ about it.
3) Test failure SettingsChangePictureBrowserTest.ChangePicture. @tommycli: Could
you take a look at this failure?
4) Compiler errors (so far discovered one in iron-input). Contacted rictic@
about it, waiting for response.

[michaelpg, 2016-04-07 00:57:50]

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#~1.1.2",
On 2016/04/06 19:34:21, dpapad wrote:
> Lines 64-65 should probably use "#^a.b.c" instead of "#~a.b.c", right? Just
> noticed this.

yeah, ^1.0.0

[Dan Beam, 2016-04-07 01:00:44]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-04-07 01:00:46]

On 2016/04/07 00:43:47, dpapad wrote:
> 1) Test failure FindInPageControllerTest.SearchWithinSpecialURL (dbeam@ is
> investigating, thanks).

https://codereview.chromium.org/1855393007/

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/1/third_party/polymer/v1_0/bo...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#~1.1.2",
On 2016/04/07 00:57:50, michaelpg wrote:
> On 2016/04/06 19:34:21, dpapad wrote:
> > Lines 64-65 should probably use "#^a.b.c" instead of "#~a.b.c", right? Just
> > noticed this.
> 
> yeah, ^1.0.0

we talked about this in standup today: whether it'd be worth locking down
element versions and moving them more manually rather than just always using
^1.0.0.

i think we're just paying the price for integration sooner or later.

just fyi

[dpapad, 2016-04-13 23:16:28]

On 2016/04/07 at 00:43:47, dpapad wrote:
> +tommycli
> 
> Status update:
> There four issues discovered so far blocking this Polymer roll.
> 
> 1) Test failure FindInPageControllerTest.SearchWithinSpecialURL (dbeam@ is
investigating, thanks).
> 2) neon-animated-pages flash. There is a candidate PR
https://github.com/PolymerElements/neon-animation/pull/149, but michaelpg@ and I
thought that there might be a better fix than listening for iron-select.
michaelpg@ will try to contact cdata@ about it.
> 3) Test failure SettingsChangePictureBrowserTest.ChangePicture. @tommycli:
Could you take a look at this failure?
> 4) Compiler errors (so far discovered one in iron-input). Contacted rictic@
about it, waiting for response.

FYI, the test failures mentioned at 3 seem to have been fixed after Tommy's
https://codereview.chromium.org/1871073004. So 2 and 4 are the remaining
blockers.

[Dan Beam, 2016-04-13 23:32:22]

On 2016/04/13 23:16:28, dpapad wrote:
> On 2016/04/07 at 00:43:47, dpapad wrote:
> > +tommycli
> > 
> > Status update:
> > There four issues discovered so far blocking this Polymer roll.
> > 
> > 1) Test failure FindInPageControllerTest.SearchWithinSpecialURL (dbeam@ is
> investigating, thanks).
> > 2) neon-animated-pages flash. There is a candidate PR
> https://github.com/PolymerElements/neon-animation/pull/149, but michaelpg@ and
I
> thought that there might be a better fix than listening for iron-select.
> michaelpg@ will try to contact cdata@ about it.
> > 3) Test failure SettingsChangePictureBrowserTest.ChangePicture. @tommycli:
> Could you take a look at this failure?
> > 4) Compiler errors (so far discovered one in iron-input). Contacted rictic@
> about it, waiting for response.
> 
> FYI, the test failures mentioned at 3 seem to have been fixed after Tommy's
> https://codereview.chromium.org/1871073004. So 2 and 4 are the remaining
> blockers.

4) is fixed here https://github.com/PolymerElements/iron-input/pull/86

[dpapad, 2016-04-14 00:22:11]

On 2016/04/13 at 23:32:22, dbeam wrote:
> On 2016/04/13 23:16:28, dpapad wrote:
> > On 2016/04/07 at 00:43:47, dpapad wrote:
> > > +tommycli
> > > 
> > > Status update:
> > > There four issues discovered so far blocking this Polymer roll.
> > > 
> > > 1) Test failure FindInPageControllerTest.SearchWithinSpecialURL (dbeam@ is
> > investigating, thanks).
> > > 2) neon-animated-pages flash. There is a candidate PR
> > https://github.com/PolymerElements/neon-animation/pull/149, but michaelpg@
and I
> > thought that there might be a better fix than listening for iron-select.
> > michaelpg@ will try to contact cdata@ about it.
> > > 3) Test failure SettingsChangePictureBrowserTest.ChangePicture. @tommycli:
> > Could you take a look at this failure?
> > > 4) Compiler errors (so far discovered one in iron-input). Contacted
rictic@
> > about it, waiting for response.
> > 
> > FYI, the test failures mentioned at 3 seem to have been fixed after Tommy's
> > https://codereview.chromium.org/1871073004. So 2 and 4 are the remaining
> > blockers.
> 
> 4) is fixed here https://github.com/PolymerElements/iron-input/pull/86

Forgot to update polymer_resources.grdp in my latest patch, which most likely
explains the test failures. Updating shortly again...

[dpapad, 2016-04-14 18:44:27]

Description was changed from

==========
Roll third_party/polymer.

BUG=600887
==========

to

==========
Roll third_party/polymer.

Pinned neon-animation to v1.1.0 because newer versions exhibit unexpected
animations to occur,
https://github.com/PolymerElements/neon-animation/issues/146.
==========

[dpapad, 2016-04-14 19:22:53]

Pinned neon-animated pages to specific version (see updated CL description).
There should be no blockers anymore, PTAL.

[dpapad, 2016-04-14 22:50:38]

Description was changed from

==========
Roll third_party/polymer.

Pinned neon-animation to v1.1.0 because newer versions exhibit unexpected
animations to occur,
https://github.com/PolymerElements/neon-animation/issues/146.
==========

to

==========
Roll third_party/polymer.

- Added new carbon-route element.
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.
==========

[dpapad, 2016-04-14 22:51:35]

+dschuyler
FYI, I added a new bower dependency to carbon-route element, per Dave's request.

[michaelpg, 2016-04-14 23:48:56]

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:35: "neon-animation":
"PolymerElements/neon-animation#1.1.0",
Add a comment pointing to a bug to explain this.

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#^1.1.2",
please keep these sorted

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#^1.1.2",
nit: PolymerElements for consistency

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
File ui/webui/resources/polymer_resources.grdp (right):

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
ui/webui/resources/polymer_resources.grdp:23: <structure
name="IDR_POLYMER_1_0_CARBON_ROUTE_CARBON_LOCATION_EXTRACTED_JS"
it's fine to get these from bower, but let's not compile them into Chrome until
they're actually used

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
ui/webui/resources/polymer_resources.grdp:501:
file="../../../third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js"
same: these aren't being used yet (and in fact are buggy) so let's not compile
them in

[dpapad, 2016-04-15 01:02:38]

@dschuyler: FYI, with this latest patch (patch 9) you will have to update
polymer_resources.grdp before being able to use carbon-route (basically you will
need to revert that file to how it was at patch8).

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:35: "neon-animation":
"PolymerElements/neon-animation#1.1.0",
On 2016/04/14 at 23:48:55, michaelpg wrote:
> Add a comment pointing to a bug to explain this.

I though about this, but JSON files do not support comments AFAIK. The CL
description includes the same information though. Also I don't think we will
forget about this, since we still need the neon-animation fix for
crbug.com/600887, which was the reason I started the Polymer roll in the first
place.

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:64: "paper-listbox":
"polymerelements/paper-listbox#^1.1.2",
On 2016/04/14 at 23:48:55, michaelpg wrote:
> please keep these sorted

Done (they were not sorted before though). By default when you use "bower
install --save ..." dependencies are added at the end.

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
File ui/webui/resources/polymer_resources.grdp (right):

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
ui/webui/resources/polymer_resources.grdp:23: <structure
name="IDR_POLYMER_1_0_CARBON_ROUTE_CARBON_LOCATION_EXTRACTED_JS"
On 2016/04/14 at 23:48:55, michaelpg wrote:
> it's fine to get these from bower, but let's not compile them into Chrome
until they're actually used

Done. Removed carbon-route and iron-location (only used by carbon-route) from
this file.

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
ui/webui/resources/polymer_resources.grdp:501:
file="../../../third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js"
On 2016/04/14 at 23:48:56, michaelpg wrote:
> same: these aren't being used yet (and in fact are buggy) so let's not compile
them in

Done.

I am wondering how are we going to find what is missing from this file after I
remove those. When this is done as part of the polymer roll, it is easy to
identify them because they show up as untracked files in 'git status'. When
someone starts using those, they will show up as errors in the DevTools which
can be confusing.

[dpapad, 2016-04-15 01:04:53]

Description was changed from

==========
Roll third_party/polymer.

- Added new carbon-route element.
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.
==========

to

==========
Roll third_party/polymer.

- Added new carbon-route element (but did not include in
  polymer_resources.grdp yet).
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.
==========

[michaelpg, 2016-04-15 01:19:07]

lgtm

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:35: "neon-animation":
"PolymerElements/neon-animation#1.1.0",
On 2016/04/15 01:02:38, dpapad wrote:
> On 2016/04/14 at 23:48:55, michaelpg wrote:
> > Add a comment pointing to a bug to explain this.
> 
> I though about this, but JSON files do not support comments AFAIK.

Didn't know that, guess you're right.

> The CL
> description includes the same information though. Also I don't think we will
> forget about this, since we still need the neon-animation fix for
> crbug.com/600887, which was the reason I started the Polymer roll in the first
> place.

My concern is that someone comes along and says "oh look, neon-animation is
outdated, let me fix that". They'd be wasting their time. Or worse: there are 6
OWNERS, if someone who isn't us reviews it e.g. dzhioev it could get committed.

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
File ui/webui/resources/polymer_resources.grdp (right):

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
ui/webui/resources/polymer_resources.grdp:501:
file="../../../third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js"
On 2016/04/15 01:02:38, dpapad wrote:
> On 2016/04/14 at 23:48:56, michaelpg wrote:
> > same: these aren't being used yet (and in fact are buggy) so let's not
compile
> them in
> 
> Done.
> 
> I am wondering how are we going to find what is missing from this file after I
> remove those. When this is done as part of the polymer roll, it is easy to
> identify them because they show up as untracked files in 'git status'. When
> someone starts using those, they will show up as errors in the DevTools which
> can be confusing.

we can't just add every *.html bower pulls down, there are plenty we don't use.

Whoever wants to start using paper-dropdown-menu-light or carbon-route or
whatever is intelligent enough to figure out which files are needed.

If you are using a Debug build or the gyp flag -Ddcheck_always_on (which I
recommend), Chrome will crash and show the exact URL not found.

[dpapad, 2016-04-15 01:35:57]

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
File third_party/polymer/v1_0/bower.json (right):

https://codereview.chromium.org/1862213002/diff/140001/third_party/polymer/v1...
third_party/polymer/v1_0/bower.json:35: "neon-animation":
"PolymerElements/neon-animation#1.1.0",
On 2016/04/15 at 01:19:07, michaelpg wrote:
> On 2016/04/15 01:02:38, dpapad wrote:
> > On 2016/04/14 at 23:48:55, michaelpg wrote:
> > > Add a comment pointing to a bug to explain this.
> > 
> > I though about this, but JSON files do not support comments AFAIK.
> 
> Didn't know that, guess you're right.
> 
> > The CL
> > description includes the same information though. Also I don't think we will
> > forget about this, since we still need the neon-animation fix for
> > crbug.com/600887, which was the reason I started the Polymer roll in the
first
> > place.
> 
> My concern is that someone comes along and says "oh look, neon-animation is
outdated, let me fix that". They'd be wasting their time. Or worse: there are 6
OWNERS, if someone who isn't us reviews it e.g. dzhioev it could get committed.

Agreed, this could happen. If we end up having to pin several elements to
specific versions in the future, we need to come up with a better system on
where the unblocking condition for each pinned dependency is documented.
Hopefully neon-animation will be fixed soon and the time window where an
undesired version bump could occur will be very short.

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
File ui/webui/resources/polymer_resources.grdp (right):

https://codereview.chromium.org/1862213002/diff/140001/ui/webui/resources/pol...
ui/webui/resources/polymer_resources.grdp:501:
file="../../../third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js"
On 2016/04/15 at 01:19:07, michaelpg wrote:
> On 2016/04/15 01:02:38, dpapad wrote:
> > On 2016/04/14 at 23:48:56, michaelpg wrote:
> > > same: these aren't being used yet (and in fact are buggy) so let's not
compile
> > them in
> > 
> > Done.
> > 
> > I am wondering how are we going to find what is missing from this file after
I
> > remove those. When this is done as part of the polymer roll, it is easy to
> > identify them because they show up as untracked files in 'git status'. When
> > someone starts using those, they will show up as errors in the DevTools
which
> > can be confusing.
> 
> we can't just add every *.html bower pulls down, there are plenty we don't
use.
> 
> Whoever wants to start using paper-dropdown-menu-light or carbon-route or
whatever is intelligent enough to figure out which files are needed.
> 
> If you are using a Debug build or the gyp flag -Ddcheck_always_on (which I
recommend), Chrome will crash and show the exact URL not found.

Thanks for the tip. I rarely use Debug build, but I can add this flag to my GN
setup (assuming there is an equivalent GN flag).

[dpapad, 2016-04-15 01:46:00]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-04-15 01:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1862213002/#ps180001
(title: "Remove obsolete appearance_browsertest.js, result of a previous bad
merge.")

[commit-bot: I haz the power, 2016-04-15 01:46:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862213002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862213002/180001

[commit-bot: I haz the power, 2016-04-15 01:56:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 01:56:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dpapad, 2016-04-15 17:37:21]

Description was changed from

==========
Roll third_party/polymer.

- Added new carbon-route element (but did not include in
  polymer_resources.grdp yet).
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.
==========

to

==========
Roll third_party/polymer.

- Added new carbon-route element.
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.

NOPRESUBMIT=true  # crisper.js
==========

[dpapad, 2016-04-15 17:37:30]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-04-15 17:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862213002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862213002/180001

[commit-bot: I haz the power, 2016-04-15 17:40:30]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-15 17:43:30]

Description was changed from

==========
Roll third_party/polymer.

- Added new carbon-route element.
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.

NOPRESUBMIT=true  # crisper.js
==========

to

==========
Roll third_party/polymer.

- Added new carbon-route element.
- Pinned neon-animation to v1.1.0 because newer versions
  exhibit unexpected animations to occur,
  https://github.com/PolymerElements/neon-animation/issues/146.

NOPRESUBMIT=true  # crisper.js

Committed: https://crrev.com/f63998d6e41aebef66673ff0e837165488ee6bc5
Cr-Commit-Position: refs/heads/master@{#387633}
==========

[commit-bot: I haz the power, 2016-04-15 17:43:32]

Patchset 10 (id:??) landed as
https://crrev.com/f63998d6e41aebef66673ff0e837165488ee6bc5
Cr-Commit-Position: refs/heads/master@{#387633}