Remove ContentBrowserClient::CreateRequestContext & CreateRequestContextForStoragePartition.

Remove ContentBrowserClient::CreateRequestContext & CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the request context, so these should just be on BrowserContext directly. The main motivator is to remove BrowserContext::GetRequestContext, which depends on this change since in tests the default ContentBrowserClient doesn't know which BrowserContext implementation is used.

GetRequestContext duplicates BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
NOPRESUBMIT=true

Committed: https://crrev.com/547f267cbb9baac850a63e01cdb063448538b6f4
Cr-Commit-Position: refs/heads/master@{#385855}

[jam, 2016-04-07 15:23:57]

Description was changed from

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The implementations in the various implementations just delegate to the
BrowserContext to create the request context, so these should just be on
BrowserContext directly. The main motivator is to remove
BrowserContext::GetRequestContext, which depends on this change since in tests
the default ContentBrowserClient doesn't know which BrowserContext
implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
==========

to

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
==========

[jam, 2016-04-07 18:57:14]

jam@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-04-07 19:10:05]

Overall, LGTM, but questions about modernizing it while we're in here.

https://codereview.chromium.org/1862203005/diff/140001/content/public/browser...
File content/public/browser/browser_context.h (right):

https://codereview.chromium.org/1862203005/diff/140001/content/public/browser...
content/public/browser/browser_context.h:64: ProtocolHandlerMap;
Is there a reason we can't move to scoped_ptr/unique_ptr here?

https://codereview.chromium.org/1862203005/diff/140001/extensions/shell/brows...
File extensions/shell/browser/shell_browser_context.cc (right):

https://codereview.chromium.org/1862203005/diff/140001/extensions/shell/brows...
extensions/shell/browser/shell_browser_context.cc:63:
linked_ptr<net::URLRequestJobFactory::ProtocolHandler>(
ditto

[jam, 2016-04-07 20:11:03]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:11:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862203005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862203005/140001

[jam, 2016-04-07 20:12:41]

https://codereview.chromium.org/1862203005/diff/140001/content/public/browser...
File content/public/browser/browser_context.h (right):

https://codereview.chromium.org/1862203005/diff/140001/content/public/browser...
content/public/browser/browser_context.h:64: ProtocolHandlerMap;
On 2016/04/07 19:10:05, Avi wrote:
> Is there a reason we can't move to scoped_ptr/unique_ptr here?

We should convert it; I think that should be done orthogonally from this cl
though to keep things simple.

[jam, 2016-04-07 20:22:51]

Description was changed from

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
==========

to

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
NOPRESUBMIT=true
==========

[jam, 2016-04-07 20:23:05]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-04-07 20:23:06]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:23:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862203005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862203005/140001

[commit-bot: I haz the power, 2016-04-07 21:16:35]

Description was changed from

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
NOPRESUBMIT=true
==========

to

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-04-07 21:16:38]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-07 21:29:32]

Description was changed from

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
NOPRESUBMIT=true
==========

to

==========
Remove ContentBrowserClient::CreateRequestContext &
CreateRequestContextForStoragePartition.

The various implementations just delegate to the BrowserContext to create the
request context, so these should just be on BrowserContext directly. The main
motivator is to remove BrowserContext::GetRequestContext, which depends on this
change since in tests the default ContentBrowserClient doesn't know which
BrowserContext implementation is used.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
NOPRESUBMIT=true

Committed: https://crrev.com/547f267cbb9baac850a63e01cdb063448538b6f4
Cr-Commit-Position: refs/heads/master@{#385855}
==========

[commit-bot: I haz the power, 2016-04-07 21:29:34]

Patchset 8 (id:??) landed as
https://crrev.com/547f267cbb9baac850a63e01cdb063448538b6f4
Cr-Commit-Position: refs/heads/master@{#385855}