Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 1862203005: Remove ContentBrowserClient::CreateRequestContext & CreateRequestContextForStoragePartition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_browser_context.cc
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
index 959d2b4d7227509bc65663a99e5bce8f82bafff5..d5252bd244746c99d3ee9727fb838b0b5664a800 100644
--- a/android_webview/browser/aw_browser_context.cc
+++ b/android_webview/browser/aw_browser_context.cc
@@ -269,30 +269,6 @@ void AwBrowserContext::AddVisitedURLs(const std::vector<GURL>& urls) {
visitedlink_master_->AddURLs(urls);
}
-net::URLRequestContextGetter* AwBrowserContext::CreateRequestContext(
- content::ProtocolHandlerMap* protocol_handlers,
- content::URLRequestInterceptorScopedVector request_interceptors) {
- // This function cannot actually create the request context because
- // there is a reentrant dependency on GetResourceContext() via
- // content::StoragePartitionImplMap::Create(). This is not fixable
- // until http://crbug.com/159193. Until then, assert that the context
- // has already been allocated and just handle setting the protocol_handlers.
- DCHECK(url_request_context_getter_.get());
- url_request_context_getter_->SetHandlersAndInterceptors(
- protocol_handlers, std::move(request_interceptors));
- return url_request_context_getter_.get();
-}
-
-net::URLRequestContextGetter*
-AwBrowserContext::CreateRequestContextForStoragePartition(
- const base::FilePath& partition_path,
- bool in_memory,
- content::ProtocolHandlerMap* protocol_handlers,
- content::URLRequestInterceptorScopedVector request_interceptors) {
- NOTREACHED();
- return NULL;
-}
-
AwQuotaManagerBridge* AwBrowserContext::GetQuotaManagerBridge() {
if (!quota_manager_bridge_.get()) {
quota_manager_bridge_ = native_factory_->CreateAwQuotaManagerBridge(this);
@@ -439,6 +415,30 @@ AwBrowserContext::GetBackgroundSyncController() {
return nullptr;
}
+net::URLRequestContextGetter* AwBrowserContext::CreateRequestContext(
+ content::ProtocolHandlerMap* protocol_handlers,
+ content::URLRequestInterceptorScopedVector request_interceptors) {
+ // This function cannot actually create the request context because
+ // there is a reentrant dependency on GetResourceContext() via
+ // content::StoragePartitionImplMap::Create(). This is not fixable
+ // until http://crbug.com/159193. Until then, assert that the context
+ // has already been allocated and just handle setting the protocol_handlers.
+ DCHECK(url_request_context_getter_.get());
+ url_request_context_getter_->SetHandlersAndInterceptors(
+ protocol_handlers, std::move(request_interceptors));
+ return url_request_context_getter_.get();
+}
+
+net::URLRequestContextGetter*
+AwBrowserContext::CreateRequestContextForStoragePartition(
+ const base::FilePath& partition_path,
+ bool in_memory,
+ content::ProtocolHandlerMap* protocol_handlers,
+ content::URLRequestInterceptorScopedVector request_interceptors) {
+ NOTREACHED();
+ return NULL;
+}
+
policy::URLBlacklistManager* AwBrowserContext::GetURLBlacklistManager() {
// Should not be called until the end of PreMainMessageLoopRun, where
// blacklist_manager_ is initialized.

Powered by Google App Engine
This is Rietveld 408576698