components/data_reduction_proxy/core/common/data_reduction_proxy_params.h - Issue 1862193002: Enable QUIC for proxies only when QUIC is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

Issue 1862193002: Enable QUIC for proxies only when QUIC is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed sclittle comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/io_thread.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

index 5054abee399c48152d358a95ec53e7cb2bbd5d36..2ae80df43728d368b0e92cdbacdee071014abbec 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

@@ -184,9 +184,6 @@ class DataReductionProxyParams : public DataReductionProxyConfigValues {

~DataReductionProxyParams() override;

- // If true, uses QUIC instead of SPDY to connect to proxies that use TLS.

- void EnableQuic(bool enable);

const std::vector<net::ProxyServer>& proxies_for_http() const override;

const GURL& secure_proxy_check_url() const override;

@@ -199,8 +196,6 @@ class DataReductionProxyParams : public DataReductionProxyConfigValues {

bool holdback() const override;

- bool quic_enabled() const { return quic_enabled_; }

protected:

// Test constructor that optionally won't call Init();

DataReductionProxyParams(int flags,

@@ -235,8 +230,6 @@ class DataReductionProxyParams : public DataReductionProxyConfigValues {

bool fallback_allowed_;

bool promo_allowed_;

bool holdback_;

- bool quic_enabled_;

- std::string override_quic_origin_;

bool configured_on_command_line_;