Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 1862193002: Enable QUIC for proxies only when QUIC is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed sclittle comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
index 092c48c2006ab65776948917c59c2d1b663df82b..f20ae4a1727fc78ad9317dacc68108f0f394bfc9 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
@@ -684,65 +684,4 @@ TEST_F(DataReductionProxySettingsTest, CheckInitMetricsWhenNotAllowed) {
test_context_->RunUntilIdle();
}
-TEST_F(DataReductionProxySettingsTest, CheckQUICFieldTrials) {
- const struct {
- bool enable_quic;
- std::string field_trial_group_name;
- } tests[] = {
- {
- false, std::string(),
- },
- {
- false, "NotEnabled",
- },
- {
- false, "Control",
- },
- {
- false, "Disabled",
- },
- {
- true, "EnabledControl",
- },
- {
- true, "Enabled",
- },
- };
-
- for (size_t i = 0; i < arraysize(tests); ++i) {
- // No call to |AddProxyToCommandLine()| was made, so the proxy feature
- // should be unavailable.
- // Clear the command line. Setting flags can force the proxy to be allowed.
- base::CommandLine::ForCurrentProcess()->InitFromArgv(0, NULL);
-
- ResetSettings(false, false, false, false);
- MockSettings* settings = static_cast<MockSettings*>(settings_.get());
- EXPECT_FALSE(settings->Allowed());
- EXPECT_CALL(*settings, RecordStartupState(PROXY_NOT_AVAILABLE));
-
- settings_->InitDataReductionProxySettings(
- test_context_->GetDataReductionProxyEnabledPrefName(),
- test_context_->pref_service(), test_context_->io_data(),
- test_context_->CreateDataReductionProxyService(settings_.get()));
-
- base::FieldTrialList field_trial_list(new base::MockEntropyProvider());
-
- base::FieldTrialList::CreateFieldTrial(params::GetQuicFieldTrialName(),
- tests[i].field_trial_group_name);
- EXPECT_EQ(
- tests[i].field_trial_group_name,
- base::FieldTrialList::FindFullName(params::GetQuicFieldTrialName()));
- test_context_->config()->EnableQuic(tests[i].enable_quic);
-
- settings_->SetCallbackToRegisterSyntheticFieldTrial(
- base::Bind(&DataReductionProxySettingsTestBase::
- SyntheticFieldTrialRegistrationCallback,
- base::Unretained(this)));
-
- net::ProxyServer origin =
- test_context_->config()->test_params()->proxies_for_http().front();
- EXPECT_EQ(tests[i].enable_quic, origin.is_quic()) << i;
- }
-}
-
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698