Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1862123003: Rename both As{Byte,Wide}StringC() helpers to AsStringC(). (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename both As{Byte,Wide}StringC() helpers to AsStringC(). The naming is redundant given the base type, and will stand in the way of consolidating Byte and Wide code. BUG= Committed: https://pdfium.googlesource.com/pdfium/+/4c3debb3c91f5842784be30a911b52cdabcab7df

Patch Set 1 #

Patch Set 2 : Missed one #

Patch Set 3 : Rebase, one new usage in core/fxge/ge/fx_ge_text.cpp #

Patch Set 4 : Rebase, fix new usage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -822 lines) Patch
M core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 12 chunks +13 lines, -18 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_allstates.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 8 chunks +11 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_name.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_number.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_string.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpvt_color.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 5 chunks +8 lines, -9 lines 0 comments Download
M core/fpdfdoc/doc_action.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/doc_annot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/doc_basic.cpp View 1 2 3 5 chunks +14 lines, -15 lines 0 comments Download
M core/fpdfdoc/doc_bookmark.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/doc_form.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/doc_formcontrol.cpp View 5 chunks +9 lines, -11 lines 0 comments Download
M core/fpdfdoc/doc_formfield.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/doc_link.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_ocg.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfdoc/doc_tagged.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M core/fpdfdoc/doc_utils.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M core/fxcrt/fx_basic_bstring.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_xml_parser.cpp View 5 chunks +6 lines, -7 lines 0 comments Download
M core/fxcrt/fxcrt_posix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/fx_basic.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/fx_string.h View 1 2 3 4 chunks +16 lines, -16 lines 0 comments Download
M core/fxge/ge/fx_ge_ps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_baseannot.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 2 8 chunks +9 lines, -10 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 2 3 6 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 2 3 7 chunks +12 lines, -16 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Label.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Signature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/libfuzzer/pdf_fm2js_fuzzer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fee/fde_txtedtengine.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 13 chunks +25 lines, -26 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/BC_UtilCodingConvert.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_codabar.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M xfa/fxbarcode/cbc_code128.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M xfa/fxbarcode/cbc_code39.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M xfa/fxbarcode/cbc_datamatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_ean13.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M xfa/fxbarcode/cbc_ean8.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M xfa/fxbarcode/cbc_pdf417i.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_qrcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_upca.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCodaBarWriter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCode39Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 1 2 10 chunks +21 lines, -27 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 107 chunks +170 lines, -184 lines 0 comments Download
M xfa/fxfa/parser/cxfa_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_validate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 1 2 8 chunks +13 lines, -13 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 7 chunks +7 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 5 chunks +7 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 70 chunks +102 lines, -118 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 2 10 chunks +12 lines, -14 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 25 chunks +36 lines, -40 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 9 chunks +16 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Tom Sepez
Lei, nothing but sed. I wanted to tackle this before it spread further. Thanks.
4 years, 8 months ago (2016-04-06 23:07:04 UTC) #2
Tom Sepez
On 2016/04/06 23:07:04, Tom Sepez wrote: > Lei, nothing but sed. I wanted to tackle ...
4 years, 8 months ago (2016-04-08 16:09:27 UTC) #3
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-08 19:13:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862123003/60001
4 years, 8 months ago (2016-04-08 19:20:17 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 19:20:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/4c3debb3c91f5842784be30a911b52cdabca...

Powered by Google App Engine
This is Rietveld 408576698