bluetooth: replace GattServices D-Bus property with ServicesResolved

device/bluetooth/bluetooth_adapter_bluez.cc

Index: device/bluetooth/bluetooth_adapter_bluez.cc
diff --git a/device/bluetooth/bluetooth_adapter_bluez.cc b/device/bluetooth/bluetooth_adapter_bluez.cc
index 91345fcaa8534237b000e057c5016e39033443e0..6a20efd76ec43e6d2a553bca64478051bddb53bd 100644
--- a/device/bluetooth/bluetooth_adapter_bluez.cc
+++ b/device/bluetooth/bluetooth_adapter_bluez.cc
@@ -525,7 +525,9 @@ void BluetoothAdapterBlueZ::DevicePropertyChanged(
     NotifyDeviceChanged(device_bluez);
   }
 
-  if (property_name == properties->gatt_services.name()) {
+  if ((property_name == properties->gatt_services.name()) ||
+      (property_name == properties->services_resolved.name() &&
+       properties->services_resolved.value())) {
     device_bluez->SetGattServicesDiscoveryComplete(true);

[ortuno, 2016/04/07 15:34:59]

I don't think we need to keep track of the value ourselves anymore. I would
recommend making IsGattServicesDiscoveryComplete in bluetooth_device.h virtual
and implement  IsGattServicesDiscoveryComplete in bluetooth_device_bluez.h/cc.
The implementation would just access the property directly.

Also override SetGattServicesDiscoveryComplete in bluetooth_device_bluez and
add:

// Bluez keeps track of the discovery state.
NOTIMPLEMENTED()

[vudentz, 2016/04/07 17:59:33]

I was wondering myself why there was two very similar method being called one
after the other, anyway what you are suggesting doesn't sound backward
compatible since GattServices doesn't track service discovery properly.

[ortuno, 2016/04/08 19:24:17]

I think we should wait until we roll bluez again and then just land without the
backwards compatible code. Once we launch Web Bluetooth on Linux we will need to
keep old version in mind but until then I think it's best to keep the codebase
lean.

     NotifyGattServicesDiscovered(device_bluez);
   }