bluetooth: replace GattServices D-Bus property with ServicesResolved

device/bluetooth/bluetooth_adapter_bluez.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_adapter_bluez.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 507 matching lines @@
       property_name == properties->alias.name() ||
       property_name == properties->paired.name() ||
       property_name == properties->trusted.name() ||
       property_name == properties->connected.name() ||
       property_name == properties->uuids.name() ||
       property_name == properties->rssi.name() ||
       property_name == properties->tx_power.name()) {
     NotifyDeviceChanged(device_bluez);
   }
 
-  if (property_name == properties->gatt_services.name()) {
+  if ((property_name == properties->gatt_services.name()) ||
+      (property_name == properties->services_resolved.name() &&
+       properties->services_resolved.value())) {
     device_bluez->SetGattServicesDiscoveryComplete(true);

[ortuno, 2016/04/07 15:34:59]

I don't think we need to keep track of the value ourselves anymore. I would
recommend making IsGattServicesDiscoveryComplete in bluetooth_device.h virtual
and implement  IsGattServicesDiscoveryComplete in bluetooth_device_bluez.h/cc.
The implementation would just access the property directly.

Also override SetGattServicesDiscoveryComplete in bluetooth_device_bluez and
add:

// Bluez keeps track of the discovery state.
NOTIMPLEMENTED()

[vudentz, 2016/04/07 17:59:33]

I was wondering myself why there was two very similar method being called one
after the other, anyway what you are suggesting doesn't sound backward
compatible since GattServices doesn't track service discovery properly.

[ortuno, 2016/04/08 19:24:17]

I think we should wait until we roll bluez again and then just land without the
backwards compatible code. Once we launch Web Bluetooth on Linux we will need to
keep old version in mind but until then I think it's best to keep the codebase
lean.

     NotifyGattServicesDiscovered(device_bluez);
   }
 
   // When a device becomes paired, mark it as trusted so that the user does
   // not need to approve every incoming connection
   if (property_name == properties->paired.name() &&
       properties->paired.value() && !properties->trusted.value()) {
     device_bluez->SetTrusted();
   }
 
@@ skipping 909 matching lines @@
 
     // If the queued request resulted in a pending call, then let it
     // asynchonously process the remaining queued requests once the pending
     // call returns.
     if (discovery_request_pending_)
       return;
   }
 }
 
 }  // namespace bluez