src/log.cc - Issue 18620002: Do not store fp and sp values in TickSample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 18620002: Do not store fp and sp values in TickSample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed fp Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 7fd6cf47b715fff7ea87945f30cbb30ccf9fa786..4a762bfb1890085d803a5085c49af656a5ffdd2b 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -1353,8 +1353,6 @@ void Logger::TickEvent(TickSample* sample, bool overflow) {

LogMessageBuilder msg(this);

msg.Append("%s,", kLogEventsNames[TICK_EVENT]);

msg.AppendAddress(sample->pc);

- msg.Append(',');

- msg.AppendAddress(sample->sp);

msg.Append(",%ld", static_cast<int>(OS::Ticks() - epoch_));

if (sample->has_external_callback) {

msg.Append(",1,");

« src/frames.cc ('K') | « src/frames.cc ('k') | src/sampler.h » ('j') | no next file with comments »