Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: src/log.cc

Issue 18620002: Do not store fp and sp values in TickSample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed fp Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/frames.cc ('K') | « src/frames.cc ('k') | src/sampler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1335 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 DeleteArray(parameter_string); 1346 DeleteArray(parameter_string);
1347 msg.WriteToLogFile(); 1347 msg.WriteToLogFile();
1348 } 1348 }
1349 1349
1350 1350
1351 void Logger::TickEvent(TickSample* sample, bool overflow) { 1351 void Logger::TickEvent(TickSample* sample, bool overflow) {
1352 if (!log_->IsEnabled() || !FLAG_prof) return; 1352 if (!log_->IsEnabled() || !FLAG_prof) return;
1353 LogMessageBuilder msg(this); 1353 LogMessageBuilder msg(this);
1354 msg.Append("%s,", kLogEventsNames[TICK_EVENT]); 1354 msg.Append("%s,", kLogEventsNames[TICK_EVENT]);
1355 msg.AppendAddress(sample->pc); 1355 msg.AppendAddress(sample->pc);
1356 msg.Append(',');
1357 msg.AppendAddress(sample->sp);
1358 msg.Append(",%ld", static_cast<int>(OS::Ticks() - epoch_)); 1356 msg.Append(",%ld", static_cast<int>(OS::Ticks() - epoch_));
1359 if (sample->has_external_callback) { 1357 if (sample->has_external_callback) {
1360 msg.Append(",1,"); 1358 msg.Append(",1,");
1361 msg.AppendAddress(sample->external_callback); 1359 msg.AppendAddress(sample->external_callback);
1362 } else { 1360 } else {
1363 msg.Append(",0,"); 1361 msg.Append(",0,");
1364 msg.AppendAddress(sample->tos); 1362 msg.AppendAddress(sample->tos);
1365 } 1363 }
1366 msg.Append(",%d", static_cast<int>(sample->state)); 1364 msg.Append(",%d", static_cast<int>(sample->state));
1367 if (overflow) { 1365 if (overflow) {
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
1801 profiler_ = NULL; 1799 profiler_ = NULL;
1802 } 1800 }
1803 1801
1804 delete ticker_; 1802 delete ticker_;
1805 ticker_ = NULL; 1803 ticker_ = NULL;
1806 1804
1807 return log_->Close(); 1805 return log_->Close();
1808 } 1806 }
1809 1807
1810 } } // namespace v8::internal 1808 } } // namespace v8::internal
OLDNEW
« src/frames.cc ('K') | « src/frames.cc ('k') | src/sampler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698