src/frames.cc - Issue 18620002: Do not store fp and sp values in TickSample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 18620002: Do not store fp and sp values in TickSample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed fp Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index 4afd4d49d15c4d60e3026ad9b5beea20da12ce12..c0e81013deb9082e281dec05959d8a936f1019d6 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -216,9 +216,9 @@ bool StackTraceFrameIterator::IsValidFrame() {

SafeStackFrameIterator::SafeStackFrameIterator(

Isolate* isolate,

- Address fp, Address sp, Address low_bound, Address high_bound) :

+ Address fp, Address sp, Address js_entry_sp) :

StackFrameIteratorBase(isolate, false),

Jakob Kummerow 2013/07/03 14:12:31 nit: while you're here, please move the ':' onto t

yurys 2013/07/03 14:16:41 Done.

- low_bound_(low_bound), high_bound_(high_bound),

+ low_bound_(sp), high_bound_(js_entry_sp),

top_frame_type_(StackFrame::NONE) {

StackFrame::State state;

StackFrame::Type type;

« no previous file with comments | « src/frames.h ('k') | src/log.cc » ('j') | no next file with comments »