MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(),
respectively.

I was going to do the same HTMLCanvasElementCapture, but
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760
[1] https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-

Committed: https://crrev.com/579ac73af399f0f16cfde8d0cda23ff1ec30750a
Cr-Commit-Position: refs/heads/master@{#385515}

[mcasas, 2016-04-06 17:29:14]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org

[mcasas, 2016-04-06 17:29:15]

emircan@ PTAL

(assuming bots are happy).

[mcasas, 2016-04-06 17:52:01]

Description was changed from

==========
MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), used them instead of
ASSERT() and ASSERT_NOT_REACHED(), respectively.

I was going to do the same HTMLCanvasElementCapture, but removed the
DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1]
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...
==========

to

==========
MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(), 
respectively.

I was going to do the same HTMLCanvasElementCapture, but 
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1]
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...
==========

[emircan, 2016-04-06 18:21:31]

lgtm

[mcasas, 2016-04-06 18:47:16]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:47:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861963004/1

[commit-bot: I haz the power, 2016-04-06 18:56:20]

Description was changed from

==========
MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(), 
respectively.

I was going to do the same HTMLCanvasElementCapture, but 
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1]
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...
==========

to

==========
MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(), 
respectively.

I was going to do the same HTMLCanvasElementCapture, but 
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1]
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...
==========

[commit-bot: I haz the power, 2016-04-06 18:56:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 18:57:19]

Description was changed from

==========
MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(), 
respectively.

I was going to do the same HTMLCanvasElementCapture, but 
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1]
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...
==========

to

==========
MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(),
respectively.

I was going to do the same HTMLCanvasElementCapture, but
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1]
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...

Committed: https://crrev.com/579ac73af399f0f16cfde8d0cda23ff1ec30750a
Cr-Commit-Position: refs/heads/master@{#385515}
==========

[commit-bot: I haz the power, 2016-04-06 18:57:20]

Patchset 1 (id:??) landed as
https://crrev.com/579ac73af399f0f16cfde8d0cda23ff1ec30750a
Cr-Commit-Position: refs/heads/master@{#385515}

[haraken, 2016-04-06 23:44:57]

LGTM