Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

Issue 1861963004: MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
index 80f1a9d9398bab82e2b63a17fe9241a236daa1a2..ce48adf7a8b8b52222ed2cdb17c8e14c9c4c8cc1 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
@@ -38,7 +38,7 @@ String stateToString(MediaRecorder::State state)
return "paused";
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return String();
}
@@ -88,7 +88,7 @@ void AllocateVideoAndAudioBitrates(ExceptionState& exceptionState, ExecutionCont
audioBps = kSmallestPossibleOpusBitRate;
}
} else {
- ASSERT(!audioBps);
+ DCHECK(!audioBps);
}
}
@@ -103,7 +103,7 @@ void AllocateVideoAndAudioBitrates(ExceptionState& exceptionState, ExecutionCont
videoBps = kSmallestPossibleVpxBitRate;
}
} else {
- ASSERT(!videoBps);
+ DCHECK(!videoBps);
}
}
@@ -143,10 +143,10 @@ MediaRecorder::MediaRecorder(ExecutionContext* context, MediaStream* stream, con
, m_state(State::Inactive)
, m_dispatchScheduledEventRunner(AsyncMethodRunner<MediaRecorder>::create(this, &MediaRecorder::dispatchScheduledEvent))
{
- ASSERT(m_stream->getTracks().size());
+ DCHECK(m_stream->getTracks().size());
m_recorderHandler = adoptPtr(Platform::current()->createMediaRecorderHandler());
- ASSERT(m_recorderHandler);
+ DCHECK(m_recorderHandler);
if (!m_recorderHandler) {
exceptionState.throwDOMException(NotSupportedError, "No MediaRecorder handler can be created.");
@@ -323,7 +323,7 @@ void MediaRecorder::createBlobEvent(Blob* blob)
void MediaRecorder::stopRecording()
{
- ASSERT(m_state != State::Inactive);
+ DCHECK(m_state != State::Inactive);
m_state = State::Inactive;
m_recorderHandler->stop();
« no previous file with comments | « third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698