[Extensions UI] Don't pop out an overflowed action on item uninstall

[Extensions UI] Don't pop out an overflowed action on item uninstall

If an extension is uninstalled, we shouldn't pop out a previously-
overflowed extension. We still do this for an extension being
disabled because we want a disable->enable cycle to maintain toolbar
width and position.

Change behavior for uninstall and add a test.

BUG=599362
Committed: https://crrev.com/12671aca120fb0ffe0b61644b59035da504de9a5
Cr-Commit-Position: refs/heads/master@{#385811}

[Devlin, 2016-04-07 04:03:40]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-04-07 04:06:36]

Description was changed from

==========
Pop out
BUG=
==========

to

==========
[Extensions UI] Don't pop out an overflowed action on item uninstall

If an extension is uninstalled, we shouldn't pop out a previously-
overflowed extension. We still do this for an extension being
disabled because we want a disable->enable cycle to maintain toolbar
width and position.

Change behavior for uninstall and add a test.

BUG=599362
==========

[Devlin, 2016-04-07 04:06:59]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2016-04-07 04:06:59]

Finnur, can you take a look?

[Finnur, 2016-04-07 10:14:14]

Hmm... that looks relatively painless to implement. Hope you don't get calls to
do the same for disable/enable, which might prove trickier. :)

LGTM.

https://codereview.chromium.org/1861943002/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_model.cc (right):

https://codereview.chromium.org/1861943002/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_model.cc:235: index <
visible_icon_count() && !all_icons_visible();
Nit: I wonder if this should be a private util function in this class. I'll
leave it up to you.

[Devlin, 2016-04-07 17:16:48]

https://codereview.chromium.org/1861943002/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_model.cc (right):

https://codereview.chromium.org/1861943002/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_model.cc:235: index <
visible_icon_count() && !all_icons_visible();
On 2016/04/07 10:14:13, Finnur wrote:
> Nit: I wonder if this should be a private util function in this class. I'll
> leave it up to you.

Since it's only used here (that I saw), I think it's probably okay to leave it
inlined - I think the bool serves the same purpose that a function in would in
that it documents what it signifies.

[Devlin, 2016-04-07 17:16:54]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-04-07 17:17:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861943002/20001

[commit-bot: I haz the power, 2016-04-07 18:18:54]

Description was changed from

==========
[Extensions UI] Don't pop out an overflowed action on item uninstall

If an extension is uninstalled, we shouldn't pop out a previously-
overflowed extension. We still do this for an extension being
disabled because we want a disable->enable cycle to maintain toolbar
width and position.

Change behavior for uninstall and add a test.

BUG=599362
==========

to

==========
[Extensions UI] Don't pop out an overflowed action on item uninstall

If an extension is uninstalled, we shouldn't pop out a previously-
overflowed extension. We still do this for an extension being
disabled because we want a disable->enable cycle to maintain toolbar
width and position.

Change behavior for uninstall and add a test.

BUG=599362
==========

[commit-bot: I haz the power, 2016-04-07 18:18:55]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-04-07 18:20:02]

Description was changed from

==========
[Extensions UI] Don't pop out an overflowed action on item uninstall

If an extension is uninstalled, we shouldn't pop out a previously-
overflowed extension. We still do this for an extension being
disabled because we want a disable->enable cycle to maintain toolbar
width and position.

Change behavior for uninstall and add a test.

BUG=599362
==========

to

==========
[Extensions UI] Don't pop out an overflowed action on item uninstall

If an extension is uninstalled, we shouldn't pop out a previously-
overflowed extension. We still do this for an extension being
disabled because we want a disable->enable cycle to maintain toolbar
width and position.

Change behavior for uninstall and add a test.

BUG=599362

Committed: https://crrev.com/12671aca120fb0ffe0b61644b59035da504de9a5
Cr-Commit-Position: refs/heads/master@{#385811}
==========

[commit-bot: I haz the power, 2016-04-07 18:20:03]

Patchset 1 (id:??) landed as
https://crrev.com/12671aca120fb0ffe0b61644b59035da504de9a5
Cr-Commit-Position: refs/heads/master@{#385811}