Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Issue 1861943002: [Extensions UI] Don't pop out an overflowed action on item uninstall (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
index aa0ec502ba5873484d44bc39c9a046d4878097cd..4aefeded34de1fb126ac287c46509a886bae5084 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
@@ -5,6 +5,7 @@
#include <stddef.h>
#include "base/callback.h"
+#include "base/callback_helpers.h"
#include "base/files/file_util.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -1458,6 +1459,30 @@ TEST_F(ToolbarActionsModelUnitTest,
}
TEST_F(ToolbarActionsModelUnitTest,
+ TestUninstallVisibleExtensionDoesntBringOutOther) {
+ Init();
+ ASSERT_TRUE(AddBrowserActionExtensions());
+ toolbar_model()->SetVisibleIconCount(2u);
+ EXPECT_EQ(3u, num_toolbar_items());
+ EXPECT_EQ(2u, toolbar_model()->visible_icon_count());
+ EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(0u));
+ EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(1u));
+ EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(2u));
+
+ service()->UninstallExtension(
+ browser_action_b()->id(),
+ extensions::UNINSTALL_REASON_FOR_TESTING,
+ base::Bind(&base::DoNothing),
+ nullptr);
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(2u, num_toolbar_items());
+ EXPECT_EQ(1u, toolbar_model()->visible_icon_count());
+ EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(0u));
+ EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(1u));
+}
+
+TEST_F(ToolbarActionsModelUnitTest,
NoMigrationToComponentActionWithoutExtension) {
extensions::FeatureSwitch::ScopedOverride enable_redesign(
extensions::FeatureSwitch::extension_action_redesign(), true);

Powered by Google App Engine
This is Rietveld 408576698