Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 1861843002: Update DropShadowImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : Fix fuzz #

Total comments: 2

Patch Set 4 : Address code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -106 lines) Patch
M fuzz/FilterFuzz.cpp View 1 2 3 1 chunk +9 lines, -12 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 8 chunks +25 lines, -36 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download
M gm/imagefiltersbase.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefiltersstroked.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 2 chunks +9 lines, -12 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 1 2 3 2 chunks +20 lines, -6 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 3 1 chunk +9 lines, -12 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861843002/20001
4 years, 8 months ago (2016-04-05 22:49:15 UTC) #5
robertphillips
4 years, 8 months ago (2016-04-05 22:49:19 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1730) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
4 years, 8 months ago (2016-04-05 22:50:46 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861843002/40001
4 years, 8 months ago (2016-04-05 23:03:16 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 23:12:47 UTC) #12
f(malita)
lgtm https://codereview.chromium.org/1861843002/diff/40001/include/effects/SkDropShadowImageFilter.h File include/effects/SkDropShadowImageFilter.h (right): https://codereview.chromium.org/1861843002/diff/40001/include/effects/SkDropShadowImageFilter.h#newcode31 include/effects/SkDropShadowImageFilter.h:31: color, shadowMode, input, std::move(input)
4 years, 8 months ago (2016-04-06 14:01:43 UTC) #13
robertphillips
https://codereview.chromium.org/1861843002/diff/40001/include/effects/SkDropShadowImageFilter.h File include/effects/SkDropShadowImageFilter.h (right): https://codereview.chromium.org/1861843002/diff/40001/include/effects/SkDropShadowImageFilter.h#newcode31 include/effects/SkDropShadowImageFilter.h:31: color, shadowMode, input, On 2016/04/06 14:01:43, f(malita) wrote: > ...
4 years, 8 months ago (2016-04-06 14:57:10 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861843002/60001
4 years, 8 months ago (2016-04-06 14:57:20 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 15:32:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861843002/60001
4 years, 8 months ago (2016-04-06 15:40:01 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 15:41:03 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c416912da4840af0c49bd8cdcf00044ed39500f6

Powered by Google App Engine
This is Rietveld 408576698