gm/imagefiltersscaled.cpp - Issue 1861843002: Update DropShadowImageFilter to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/imagefiltersscaled.cpp

Issue 1861843002: Update DropShadowImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address code review issues Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/imagefiltersscaled.cpp

diff --git a/gm/imagefiltersscaled.cpp b/gm/imagefiltersscaled.cpp

index a63e99af4a4fa35a7a3b922596fa7cc1f18b7a6c..46f998cc2841abb1aa98d7546501f54f9cfaa35c 100644

--- a/gm/imagefiltersscaled.cpp

+++ b/gm/imagefiltersscaled.cpp

@@ -74,9 +74,9 @@ protected:

SkImageFilter* filters[] = {

SkBlurImageFilter::Make(SkIntToScalar(4), SkIntToScalar(4), nullptr).release(),

- SkDropShadowImageFilter::Create(SkIntToScalar(5), SkIntToScalar(10),

+ SkDropShadowImageFilter::Make(SkIntToScalar(5), SkIntToScalar(10),

SkIntToScalar(3), SkIntToScalar(3), SK_ColorYELLOW,

- SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode),

+ SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode, nullptr).release(),

SkDisplacementMapEffect::Create(SkDisplacementMapEffect::kR_ChannelSelectorType,

SkDisplacementMapEffect::kR_ChannelSelectorType,

SkIntToScalar(12),

« no previous file with comments | « gm/imagefilterscropexpand.cpp ('k') | gm/imagefiltersstroked.cpp » ('j') | no next file with comments »