Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1861813002: Merge to M50: Re-land "Only place primitive objects on the V8 global template." (Closed)

Created:
4 years, 8 months ago by Oliver Chang
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@2661
Target Ref:
refs/heads/chromium/2661
Visibility:
Public.

Description

Merge to M50: Re-land "Only place primitive objects on the V8 global template." This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168. Prevent handles from being destructed after v8 is gone. BUG=pdfium:419, 600777 Original Review URL: https://codereview.chromium.org/1761073006 . (cherry picked from commit 297b515e3d53095e36991480a194b54ce887757b) R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f268cc9b8f4610acd22684ced01150e67c737fe7

Patch Set 1 : Original cherry pick (with conflict in Consts.cpp) #

Patch Set 2 : resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -187 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 1 6 chunks +92 lines, -181 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 2 chunks +4 lines, -0 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Oliver Chang
Tom, for review. Minor conflict in Consts.cpp
4 years, 8 months ago (2016-04-05 19:18:31 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-05 19:20:15 UTC) #3
Oliver Chang
4 years, 8 months ago (2016-04-05 19:22:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f268cc9b8f4610acd22684ced01150e67c737fe7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698