Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1761073006: Re-land "Only place primitive objects on the V8 global template."" (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land "Only place primitive objects on the V8 global template." This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168. Prevent handles from being destructed after v8 is gone. BUG=pdfium:419 R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/297b515e3d53095e36991480a194b54ce887757b

Patch Set 1 : Original Patch (unchanged) #

Patch Set 2 : Leak the handles. #

Patch Set 3 : Better solution - destroy handles before runtime. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -187 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 6 chunks +92 lines, -181 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 2 2 chunks +4 lines, -0 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tom Sepez
ochang, manual review between ps2 and ps1 (ps1 already blessed by Jochen). Better to leak ...
4 years, 9 months ago (2016-03-04 20:44:11 UTC) #3
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-04 20:51:18 UTC) #4
Tom Sepez
Oliver, one more quick look.
4 years, 9 months ago (2016-03-04 21:34:59 UTC) #5
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-04 21:36:16 UTC) #6
Tom Sepez
4 years, 9 months ago (2016-03-04 21:43:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
297b515e3d53095e36991480a194b54ce887757b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698