Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1861773002: Revert of Don't use pending NavigationEntries for navigation transfers. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't use pending NavigationEntries for navigation transfers. (patchset #5 id:80001 of https://codereview.chromium.org/1683593002/ ) Reason for revert: This is causing crashes in https://crbug.com/600743, as well as a problem with interstitial pages in https://crbug.com/600046. I'll look into the problems and then reland this. Original issue's description: > Don't use pending NavigationEntries for navigation transfers. > > Cross-process transfers for navigations that are about to commit > had been using NavigationControllerImpl::LoadURLWithParams (as > an artifact of previously going through OpenURL). Most of that > code is unnecessary, in particular the fact that it creates a > new pending NavigationEntry. That's problematic for subframe > transfers, where we should not affect any existing pending > NavigationEntry (e.g., for a slow main frame navigation). > > This CL shortcuts the transfer by creating a NavigationEntry > without making it the pending one. A future CL can eliminate > the entry entirely by validating and passing the parameters > to the right RenderFrameHost directly. > > This also makes it possible to do cross-process navigations > in subframes of the initial blank page, fixing a crash. > > BUG=495161, 584739 > TEST=Create OOPIF on initial blank page of a tab. > TEST=Cross-process subframe navigation during slow main frame navigation. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/9bc97a7b5405403cd9878556162a6234ef4381bf > Cr-Commit-Position: refs/heads/master@{#384009} TBR=alexmos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=495161, 584739 Committed: https://crrev.com/e737670f4917aa311ec5c583d9e1ac9386d46225 Cr-Commit-Position: refs/heads/master@{#385235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -53 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +11 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Charlie Reis
Created Revert of Don't use pending NavigationEntries for navigation transfers.
4 years, 8 months ago (2016-04-05 17:28:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861773002/1
4 years, 8 months ago (2016-04-05 17:29:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861773002/1
4 years, 8 months ago (2016-04-05 17:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861773002/1
4 years, 8 months ago (2016-04-05 18:01:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861773002/1
4 years, 8 months ago (2016-04-05 18:31:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 18:38:10 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:40:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e737670f4917aa311ec5c583d9e1ac9386d46225
Cr-Commit-Position: refs/heads/master@{#385235}

Powered by Google App Engine
This is Rietveld 408576698