content/browser/frame_host/navigation_controller_impl_browsertest.cc - Issue 1861773002: Revert of Don't use pending NavigationEntries for navigation transfers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 1861773002: Revert of Don't use pending NavigationEntries for navigation transfers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

index a6aef93555b1e3c66be8b3febefcc3bca5261bc6..cf9c8c79ecf8fda878cea954f280ea01daf508e6 100644

--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

@@ -507,13 +507,12 @@

ASSERT_EQ(1U, new_root->child_count());

ASSERT_NE(nullptr, new_root->child_at(0));

- // Navigate it cross-site.

+ // Navigate it.

GURL frame_url = embedded_test_server()->GetURL(

- "foo.com", "/navigation_controller/simple_page_2.html");

+ "/navigation_controller/simple_page_2.html");

script = "location.assign('" + frame_url.spec() + "')";

EXPECT_TRUE(content::ExecuteScript(

new_root->child_at(0)->current_frame_host(), script));

- WaitForLoadStopWithoutSuccessCheck(new_shell->web_contents());

// Success is not crashing, and not navigating.

EXPECT_EQ(nullptr,

« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »