chromeos: Turn off displays on suspend

ui/display/chromeos/display_configurator.h

Index: ui/display/chromeos/display_configurator.h
diff --git a/ui/display/chromeos/display_configurator.h b/ui/display/chromeos/display_configurator.h
index aba0fa67a43170e8875471a608cc9ffa00ee81f2..784a48b3880fc2f73cc24af5ec0fbedce40de2ac 100644
--- a/ui/display/chromeos/display_configurator.h
+++ b/ui/display/chromeos/display_configurator.h
@@ -300,13 +300,12 @@ class DISPLAY_EXPORT DisplayConfigurator : public NativeDisplayObserver {
   typedef std::map<ContentProtectionClientId, ContentProtections>
       ProtectionRequests;
 
+  void SetDisplayPowerInternal(chromeos::DisplayPowerState power_state,
+                               int flags,
+                               const ConfigurationCallback& callback);

[Daniel Erat, 2016/04/21 22:16:41]

nit: add a blank line after this line

[dbasehore, 2016/04/21 22:35:10]

Done.

   // Configures displays. Invoked by |configure_timer_|.
   void ConfigureDisplays();
 
-  // Restores |requested_power_state_| after the system has resumed,
-  // additionally forcing a probe. Invoked by |configure_timer_|.
-  void RestoreRequestedPowerStateAfterResume();
-
   // Notifies observers about an attempted state change.
   void NotifyDisplayStateObservers(bool success,
                                    MultipleDisplayState attempted_state);
@@ -394,11 +393,15 @@ class DISPLAY_EXPORT DisplayConfigurator : public NativeDisplayObserver {
   // Stores the requested power state.
   chromeos::DisplayPowerState requested_power_state_;
 
+  // Stores the power state to configure. May be the requested_power_state_ or
+  // DISPLAY_POWER_ALL_OFF for suspend.
+  chromeos::DisplayPowerState config_power_state_;

[Daniel Erat, 2016/04/21 22:16:41]

nit: configured_power_state_? maybe current_power_state_ is even clearer?

[dbasehore, 2016/04/21 22:35:10]

current_power_state already exists. configured_power_state_ implies that we
already ran the configuration. pending_power_state_?

+
   // True if |requested_power_state_| has been changed due to a user request.
-  bool requested_power_state_change_;
+  bool power_state_change_;

[Daniel Erat, 2016/04/21 22:16:41]

please give this variable a better name. the comment could also be improved; i
don't know what it's trying to say. what's a "user request"? it looks like this
gets set in the new internal method, so it doesn't seem like it's limited to
user-requested changes.

[dbasehore, 2016/04/21 22:35:10]

The name still seems to be relevant (the power state we are going to configure
with has changed). I'll update the comment. Could be pending_power_state_change_
if we go with the change above.

 
   // Bitwise-or value of the |kSetDisplayPower*| flags defined above.
-  int requested_power_flags_;
+  int config_power_flags_;

[Daniel Erat, 2016/04/21 22:16:41]

make this either "configured" or "current" too to match

[dbasehore, 2016/04/21 22:35:10]

As before. Those names imply that it was already done when we actually haven't
run the configuration task yet.

 
   // List of callbacks from callers waiting for the display configuration to
   // start/finish. Note these callbacks belong to the pending request, not a