chromeos: Turn off displays on suspend

ui/display/chromeos/display_configurator.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_DISPLAY_CHROMEOS_DISPLAY_CONFIGURATOR_H_
 #define UI_DISPLAY_CHROMEOS_DISPLAY_CONFIGURATOR_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 282 matching lines @@
                           const std::vector<GammaRampRGBEntry>& gamma_lut,
                           const std::vector<float>& correction_matrix);
 
  private:
   class DisplayLayoutManagerImpl;
 
   // Mapping a client to its protection request.
   typedef std::map<ContentProtectionClientId, ContentProtections>
       ProtectionRequests;
 
+  void SetDisplayPowerInternal(chromeos::DisplayPowerState power_state,
+                               int flags,
+                               const ConfigurationCallback& callback);

[Daniel Erat, 2016/04/21 22:16:41]

nit: add a blank line after this line

[dbasehore, 2016/04/21 22:35:10]

Done.

   // Configures displays. Invoked by |configure_timer_|.
   void ConfigureDisplays();
 
-  // Restores |requested_power_state_| after the system has resumed,
-  // additionally forcing a probe. Invoked by |configure_timer_|.
-  void RestoreRequestedPowerStateAfterResume();
-
   // Notifies observers about an attempted state change.
   void NotifyDisplayStateObservers(bool success,
                                    MultipleDisplayState attempted_state);
 
   // Notifies observers about a power state change.
   void NotifyPowerStateObservers();
 
   // Returns the display state that should be used with |cached_displays_| while
   // in |power_state|.
   MultipleDisplayState ChooseDisplayState(
@@ skipping 67 matching lines @@
 
   // Pending requests. These values are used when triggering the next display
   // configuration.
   //
   // Stores the user requested state or INVALID if nothing was requested.
   MultipleDisplayState requested_display_state_;
 
   // Stores the requested power state.
   chromeos::DisplayPowerState requested_power_state_;
 
+  // Stores the power state to configure. May be the requested_power_state_ or
+  // DISPLAY_POWER_ALL_OFF for suspend.
+  chromeos::DisplayPowerState config_power_state_;

[Daniel Erat, 2016/04/21 22:16:41]

nit: configured_power_state_? maybe current_power_state_ is even clearer?

[dbasehore, 2016/04/21 22:35:10]

current_power_state already exists. configured_power_state_ implies that we
already ran the configuration. pending_power_state_?

+
   // True if |requested_power_state_| has been changed due to a user request.
-  bool requested_power_state_change_;
+  bool power_state_change_;

[Daniel Erat, 2016/04/21 22:16:41]

please give this variable a better name. the comment could also be improved; i
don't know what it's trying to say. what's a "user request"? it looks like this
gets set in the new internal method, so it doesn't seem like it's limited to
user-requested changes.

[dbasehore, 2016/04/21 22:35:10]

The name still seems to be relevant (the power state we are going to configure
with has changed). I'll update the comment. Could be pending_power_state_change_
if we go with the change above.

 
   // Bitwise-or value of the |kSetDisplayPower*| flags defined above.
-  int requested_power_flags_;
+  int config_power_flags_;

[Daniel Erat, 2016/04/21 22:16:41]

make this either "configured" or "current" too to match

[dbasehore, 2016/04/21 22:35:10]

As before. Those names imply that it was already done when we actually haven't
run the configuration task yet.

 
   // List of callbacks from callers waiting for the display configuration to
   // start/finish. Note these callbacks belong to the pending request, not a
   // request currently active.
   std::vector<ConfigurationCallback> queued_configuration_callbacks_;
 
   // List of callbacks belonging to the currently running display configuration
   // task.
   std::vector<ConfigurationCallback> in_progress_configuration_callbacks_;
 
@@ skipping 46 matching lines @@
 
   // This must be the last variable.
   base::WeakPtrFactory<DisplayConfigurator> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DisplayConfigurator);
 };
 
 }  // namespace ui
 
 #endif  // UI_DISPLAY_CHROMEOS_DISPLAY_CONFIGURATOR_H_