Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1861293003: Suppress failing video-related WebGL conformance tests on Android (Closed)

Created:
4 years, 8 months ago by ajuma
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, liberato (no reviews please), Tobias Sargeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress failing video-related WebGL conformance tests on Android BUG=601110 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/bbb3dc7a47bc001e79134a438ca9b41600539628 Cr-Commit-Position: refs/heads/master@{#385740}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ajuma
4 years, 8 months ago (2016-04-06 18:43:00 UTC) #3
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/1861293003/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/1861293003/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode241 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:241: self.Fail('conformance/textures/video/*', This suppression seems overly broad, but OK. ...
4 years, 8 months ago (2016-04-06 22:10:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861293003/20001
4 years, 8 months ago (2016-04-06 23:25:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/206945)
4 years, 8 months ago (2016-04-07 03:15:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861293003/20001
4 years, 8 months ago (2016-04-07 13:06:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 13:32:56 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bbb3dc7a47bc001e79134a438ca9b41600539628 Cr-Commit-Position: refs/heads/master@{#385740}
4 years, 8 months ago (2016-04-07 13:34:11 UTC) #14
Tobias Sargeant
4 years, 8 months ago (2016-04-11 09:53:33 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1874273002/ by tobiasjs@chromium.org.

The reason for reverting is: Bug causing conformance test failures is fixed by
https://codereview.chromium.org/1746983002/..

Powered by Google App Engine
This is Rietveld 408576698