Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.

Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.

Methods that take string arguments and do not persist them should
take *StringC types as argument rather than discrete ptr/len args.

Avoids a number of implicit casts from CFX_ByteString to char*.

BUG=

Committed: https://pdfium.googlesource.com/pdfium/+/6fe7d2174a47107578da912299c93b4dfb9f2add

[Tom Sepez, 2016-04-05 23:49:13]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-05 23:49:14]

Lei, for review.

[Lei Zhang, 2016-04-06 00:38:02]

lgtm

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:1095: IFX_LocaleMgr* pMgr =
(IFX_LocaleMgr*)pDoc->GetLocalMgr();
BTW, there's a bunch of casts to IFX_LocaleMgr* and back to CXFA_LocaleMgr*.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:1583: if (localString.IsEmpty()) {
And this block of code seems often repeated.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:637: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
Combine with line 635.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:683: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
Combine with line 681.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:830: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
Combine with line 828.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:875: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
Combine with line 873.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:1153: wsAttributeValue =
CFX_WideString::FromUTF8(bsAttributeValue.AsByteStringC());
Combine with decl.

[Tom Sepez, 2016-04-06 17:23:13]

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:1095: IFX_LocaleMgr* pMgr =
(IFX_LocaleMgr*)pDoc->GetLocalMgr();
On 2016/04/06 00:38:01, Lei Zhang wrote:
> BTW, there's a bunch of casts to IFX_LocaleMgr* and back to CXFA_LocaleMgr*.

Acknowledged.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:1583: if (localString.IsEmpty()) {
On 2016/04/06 00:38:01, Lei Zhang wrote:
> And this block of code seems often repeated.

Acknowledged.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:637: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
On 2016/04/06 00:38:01, Lei Zhang wrote:
> Combine with line 635.

Done.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:683: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
On 2016/04/06 00:38:02, Lei Zhang wrote:
> Combine with line 681.

Done.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:830: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
On 2016/04/06 00:38:01, Lei Zhang wrote:
> Combine with line 828.

Done.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:875: wsExpression =
CFX_WideString::FromUTF8(bsExpression.AsByteStringC());
On 2016/04/06 00:38:01, Lei Zhang wrote:
> Combine with line 873.

Done.

https://codereview.chromium.org/1861183002/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:1153: wsAttributeValue =
CFX_WideString::FromUTF8(bsAttributeValue.AsByteStringC());
On 2016/04/06 00:38:01, Lei Zhang wrote:
> Combine with decl.

Done.

[Tom Sepez, 2016-04-06 17:24:58]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-06 17:24:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1861183002/#ps20001
(title: "Rebase, combine delcs with initialization.")

[commit-bot: I haz the power, 2016-04-06 17:25:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861183002/20001

[commit-bot: I haz the power, 2016-04-06 17:51:16]

Description was changed from

==========
Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.

Methods that take string arguments and do not persist them should
take *StringC types as argument rather than discrete ptr/len args.

Avoids a number of implicit casts from CFX_ByteString to char*.

BUG=
==========

to

==========
Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.

Methods that take string arguments and do not persist them should
take *StringC types as argument rather than discrete ptr/len args.

Avoids a number of implicit casts from CFX_ByteString to char*.

BUG=

Committed:
https://pdfium.googlesource.com/pdfium/+/6fe7d2174a47107578da912299c93b4dfb9f...
==========

[commit-bot: I haz the power, 2016-04-06 17:51:18]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6fe7d2174a47107578da912299c93b4dfb9f...