fpdfsdk/jsapi/fxjs_v8.cpp - Issue 1861183002: Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/jsapi/fxjs_v8.cpp

Issue 1861183002: Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, combine delcs with initialization. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/jsapi/fxjs_v8.cpp

diff --git a/fpdfsdk/jsapi/fxjs_v8.cpp b/fpdfsdk/jsapi/fxjs_v8.cpp

index 034f2c6642356a3b1f7c658992d7ed752440728c..e49eb45ce1f502954aa5e303724dd592237b576b 100644

--- a/fpdfsdk/jsapi/fxjs_v8.cpp

+++ b/fpdfsdk/jsapi/fxjs_v8.cpp

@@ -807,7 +807,7 @@ CFX_WideString FXJS_ToString(v8::Isolate* pIsolate,

return L"";

v8::Local<v8::Context> context = pIsolate->GetCurrentContext();

v8::String::Utf8Value s(pValue->ToString(context).ToLocalChecked());

- return CFX_WideString::FromUTF8(*s, s.length());

+ return CFX_WideString::FromUTF8(CFX_ByteStringC(*s, s.length()));

}

v8::Local<v8::Array> FXJS_ToArray(v8::Isolate* pIsolate,

« no previous file with comments | « fpdfsdk/javascript/JS_Define.h ('k') | testing/libfuzzer/pdf_fm2js_fuzzer.cc » ('j') | no next file with comments »