Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ppapi/tests/test_network_proxy.cc

Issue 18611004: PPAPI: Initialize CompletionCallbackWithOutput storage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/private/video_frame_private.h ('k') | ppapi/tests/test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_network_proxy.cc
diff --git a/ppapi/tests/test_network_proxy.cc b/ppapi/tests/test_network_proxy.cc
index 62a4872b1d579cc792cefb61cc4036dd6c238881..24ec9f1cbe32a813c1b579423659468079d608a2 100644
--- a/ppapi/tests/test_network_proxy.cc
+++ b/ppapi/tests/test_network_proxy.cc
@@ -60,8 +60,7 @@ std::string TestNetworkProxy::TestGetProxyForURL() {
callback.GetCallback()));
CHECK_CALLBACK_BEHAVIOR(callback);
ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
- // TODO(dmichael): Add this check below when crbug.com/250046 is fixed.
- // ASSERT_TRUE(callback.output().is_undefined());
+ ASSERT_TRUE(callback.output().is_undefined());
callback.WaitForResult(
pp::NetworkProxy::GetProxyForURL(instance_,
@@ -69,8 +68,7 @@ std::string TestNetworkProxy::TestGetProxyForURL() {
callback.GetCallback()));
CHECK_CALLBACK_BEHAVIOR(callback);
ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
- // TODO(dmichael): Add this check below when crbug.com/250046 is fixed.
- // ASSERT_TRUE(callback.output().is_undefined());
+ ASSERT_TRUE(callback.output().is_undefined());
PASS();
}
« no previous file with comments | « ppapi/cpp/private/video_frame_private.h ('k') | ppapi/tests/test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698