Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: ppapi/tests/test_network_proxy.cc

Issue 18611004: PPAPI: Initialize CompletionCallbackWithOutput storage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/cpp/private/video_frame_private.h ('k') | ppapi/tests/test_utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/tests/test_network_proxy.h" 5 #include "ppapi/tests/test_network_proxy.h"
6 6
7 #include "ppapi/cpp/instance.h" 7 #include "ppapi/cpp/instance.h"
8 #include "ppapi/cpp/network_proxy.h" 8 #include "ppapi/cpp/network_proxy.h"
9 #include "ppapi/cpp/var.h" 9 #include "ppapi/cpp/var.h"
10 #include "ppapi/tests/testing_instance.h" 10 #include "ppapi/tests/testing_instance.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 ASSERT_TRUE(output.is_string()); 53 ASSERT_TRUE(output.is_string());
54 // Should get "DIRECT" for file:// URLs. 54 // Should get "DIRECT" for file:// URLs.
55 ASSERT_EQ("DIRECT", output.AsString()); 55 ASSERT_EQ("DIRECT", output.AsString());
56 56
57 callback.WaitForResult( 57 callback.WaitForResult(
58 pp::NetworkProxy::GetProxyForURL(instance_, 58 pp::NetworkProxy::GetProxyForURL(instance_,
59 pp::Var("this isn't a url"), 59 pp::Var("this isn't a url"),
60 callback.GetCallback())); 60 callback.GetCallback()));
61 CHECK_CALLBACK_BEHAVIOR(callback); 61 CHECK_CALLBACK_BEHAVIOR(callback);
62 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 62 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
63 // TODO(dmichael): Add this check below when crbug.com/250046 is fixed. 63 ASSERT_TRUE(callback.output().is_undefined());
64 // ASSERT_TRUE(callback.output().is_undefined());
65 64
66 callback.WaitForResult( 65 callback.WaitForResult(
67 pp::NetworkProxy::GetProxyForURL(instance_, 66 pp::NetworkProxy::GetProxyForURL(instance_,
68 pp::Var(42), // non-string Var 67 pp::Var(42), // non-string Var
69 callback.GetCallback())); 68 callback.GetCallback()));
70 CHECK_CALLBACK_BEHAVIOR(callback); 69 CHECK_CALLBACK_BEHAVIOR(callback);
71 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 70 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
72 // TODO(dmichael): Add this check below when crbug.com/250046 is fixed. 71 ASSERT_TRUE(callback.output().is_undefined());
73 // ASSERT_TRUE(callback.output().is_undefined());
74 72
75 PASS(); 73 PASS();
76 } 74 }
OLDNEW
« no previous file with comments | « ppapi/cpp/private/video_frame_private.h ('k') | ppapi/tests/test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698