Issue 18611004: PPAPI: Initialize CompletionCallbackWithOutput storage

Issue 18611004: PPAPI: Initialize CompletionCallbackWithOutput storage (Closed)

Created:
7 years, 5 months ago by dmichael (off chromium)

Modified:
7 years, 5 months ago

Reviewers:
teravest, bbudge

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: Initialize CompletionCallbackWithOutput storage BUG=250046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210999

Patch Set 2 : review comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -9 lines)			Patch
M	ppapi/cpp/dev/truetype_font_dev.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ppapi/cpp/directory_entry.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/cpp/extensions/ext_output_traits.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	ppapi/cpp/output_traits.h	View		6 chunks	+18 lines, -0 lines	0 comments	Download
M	ppapi/cpp/private/pass_file_handle.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	ppapi/cpp/private/video_frame_private.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_network_proxy.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	ppapi/tests/test_utils.h	View		3 chunks	+14 lines, -5 lines	0 comments	Download
M	ppapi/utility/completion_callback_factory.h	View		5 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

teravest

lgtm https://codereview.chromium.org/18611004/diff/1/ppapi/cpp/private/video_frame_private.h File ppapi/cpp/private/video_frame_private.h (right): https://codereview.chromium.org/18611004/diff/1/ppapi/cpp/private/video_frame_private.h#newcode93 ppapi/cpp/private/video_frame_private.h:93: static inline void Initialize(StorageType* t ) { Extra ...

7 years, 5 months ago (2013-07-09 21:00:10 UTC) #2

bbudge

One thing, otherwise LGTM https://codereview.chromium.org/18611004/diff/1/ppapi/cpp/private/video_frame_private.h File ppapi/cpp/private/video_frame_private.h (right): https://codereview.chromium.org/18611004/diff/1/ppapi/cpp/private/video_frame_private.h#newcode94 ppapi/cpp/private/video_frame_private.h:94: memset(t, 0, sizeof(*t)); VideoFrame also ...

7 years, 5 months ago (2013-07-09 21:31:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/18611004/10001

7 years, 5 months ago (2013-07-10 17:20:12 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 5 months ago (2013-07-10 17:26:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/18611004/10001

7 years, 5 months ago (2013-07-10 20:07:41 UTC) #6

Message was sent while issue was closed.

Change committed as 210999

Expand Messages | Collapse Messages