third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h - Issue 1861013003: Separate metrics update and layout attribute resolving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

Issue 1861013003: Separate metrics update and layout attribute resolving (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify-layoutattr-invalidation

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

index 81a5763173e78fbca9048e431d73178640c9b6c6..9d2917c594cc6bc180492519c48b464aefa595c7 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

@@ -46,9 +46,8 @@ class SVGTextLayoutAttributesBuilder {

WTF_MAKE_NONCOPYABLE(SVGTextLayoutAttributesBuilder);

public:

SVGTextLayoutAttributesBuilder();

- bool buildLayoutAttributesForForSubtree(LayoutSVGText&);

- void rebuildMetricsForTextLayoutObject(LayoutSVGText&, LayoutSVGInlineText&);

+ void buildLayoutAttributesForTextRoot(LayoutSVGText&);

// Invoked whenever the underlying DOM tree changes, so that m_textPositions is rebuild.

void clearTextPositioningElements() { m_textPositions.clear(); }

@@ -73,6 +72,7 @@ public:

private:

void buildCharacterDataMap(LayoutSVGText&);

+ void buildLayoutAttributes(LayoutSVGText&) const;

void collectTextPositioningElements(LayoutBoxModelObject&, UChar& lastCharacter);

void fillCharacterDataMap(const TextPosition&);