Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 1861013003: Separate metrics update and layout attribute resolving (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify-layoutattr-invalidation
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
index a3fafe63669ed8cd369c6e688fd1bf452619ab10..2de7c1730e6b718d67cd8c3ed648fc7742a499b5 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
@@ -30,6 +30,7 @@
#include "core/editing/VisiblePosition.h"
#include "core/layout/svg/LayoutSVGText.h"
#include "core/layout/svg/SVGLayoutSupport.h"
+#include "core/layout/svg/SVGTextMetricsBuilder.h"
#include "core/layout/svg/line/SVGInlineTextBox.h"
namespace blink {
@@ -204,6 +205,11 @@ void LayoutSVGInlineText::updateScaledFont()
computeNewScaledFontForStyle(this, m_scalingFactor, m_scaledFont);
}
+void LayoutSVGInlineText::updateMetricsList(bool& lastCharacterWasWhiteSpace)
+{
+ SVGTextMetricsBuilder::updateTextMetrics(*this, lastCharacterWasWhiteSpace);
fs 2016/04/06 15:28:25 My current thinking is that we should just move al
pdr. 2016/04/06 23:07:33 SGTM
+}
+
void LayoutSVGInlineText::computeNewScaledFontForStyle(LayoutObject* layoutObject, float& scalingFactor, Font& scaledFont)
{
const ComputedStyle* style = layoutObject->style();

Powered by Google App Engine
This is Rietveld 408576698