Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1861013002: Delete SkFlattenable::Type (part 1) (Closed)

Created:
4 years, 8 months ago by msarett
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete SkFlattenable::Type (part 1) This should allow me to delete uses of SkFlattenable::Type in Chrome. Then I'll follow up with the full delete. https://codereview.chromium.org/1834303003/ TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002 Committed: https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M include/core/SkFlattenableSerialization.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +1 line, -7 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
msarett
4 years, 8 months ago (2016-04-05 16:05:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861013002/1
4 years, 8 months ago (2016-04-05 16:19:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce
4 years, 8 months ago (2016-04-05 16:32:38 UTC) #7
Stephen White
https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBuffer.cpp File src/core/SkValidatingReadBuffer.cpp (left): https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBuffer.cpp#oldcode235 src/core/SkValidatingReadBuffer.cpp:235: if (!SkFlattenable::NameToType(cname, &baseType) || (baseType != type)) { I ...
4 years, 8 months ago (2016-04-05 18:10:51 UTC) #11
sugoi
On 2016/04/05 18:10:51, Stephen White wrote: > https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBuffer.cpp > File src/core/SkValidatingReadBuffer.cpp (left): > > https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBuffer.cpp#oldcode235 ...
4 years, 8 months ago (2016-04-05 18:34:31 UTC) #12
msarett
4 years, 8 months ago (2016-04-05 19:00:38 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1860693005/ by msarett@google.com.

The reason for reverting is: See sugoi's comment..

Powered by Google App Engine
This is Rietveld 408576698