Delete SkFlattenable::Type (part 1)

Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002

Committed: https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce

[msarett, 2016-04-05 16:05:10]

Description was changed from

==========
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
==========

to

==========
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-05 16:05:36]

msarett@google.com changed reviewers:
+ mtklein@google.com

[msarett, 2016-04-05 16:19:38]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-04-05 16:19:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861013002/1

[commit-bot: I haz the power, 2016-04-05 16:32:37]

Description was changed from

==========
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce
==========

[commit-bot: I haz the power, 2016-04-05 16:32:38]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce

[Stephen White, 2016-04-05 18:10:11]

Description was changed from

==========
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce
==========

to

==========
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce
==========

[Stephen White, 2016-04-05 18:10:11]

senorblanco@chromium.org changed reviewers:
+ sugoi@chromium.org

[Stephen White, 2016-04-05 18:10:51]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-04-05 18:10:51]

https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBu...
File src/core/SkValidatingReadBuffer.cpp (left):

https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBu...
src/core/SkValidatingReadBuffer.cpp:235: if (!SkFlattenable::NameToType(cname,
&baseType) || (baseType != type)) {
I believe this code is necessary for security. sugoi@, please verify.

[sugoi, 2016-04-05 18:34:31]

On 2016/04/05 18:10:51, Stephen White wrote:
>
https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBu...
> File src/core/SkValidatingReadBuffer.cpp (left):
> 
>
https://codereview.chromium.org/1861013002/diff/1/src/core/SkValidatingReadBu...
> src/core/SkValidatingReadBuffer.cpp:235: if (!SkFlattenable::NameToType(cname,
> &baseType) || (baseType != type)) {
> I believe this code is necessary for security. sugoi@, please verify.

Yeah, unless someone implemented it some other way, this opens a huge security
issue in chrome.

[msarett, 2016-04-05 19:00:38]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1860693005/ by msarett@google.com.

The reason for reverting is: See sugoi's comment..