Delete SkFlattenable::Type

Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003

Committed: https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f

[msarett, 2016-03-28 22:53:44]

Description was changed from

==========
Delete SkFlattenable::Type

BUG=skia:
==========

to

==========
Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-01 14:15:40]

msarett@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-04-01 14:20:42]

https://codereview.chromium.org/1834303003/diff/1/src/core/SkValidatingReadBu...
File src/core/SkValidatingReadBuffer.cpp (left):

https://codereview.chromium.org/1834303003/diff/1/src/core/SkValidatingReadBu...
src/core/SkValidatingReadBuffer.cpp:235: if (!SkFlattenable::NameToType(cname,
&baseType) || (baseType != type)) {
Hmm.  So there's the value.

Let's sit on this until Monday when we talk with Mike.

[reed1, 2016-04-04 19:36:22]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-04-04 19:36:22]

api lgtm

[mtklein, 2016-04-04 19:38:52]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-04-04 19:38:53]

lgtm

[commit-bot: I haz the power, 2016-04-04 19:39:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834303003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834303003/1

[commit-bot: I haz the power, 2016-04-04 19:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:40:10]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-04-04 20:42:37]

The CQ bit was checked by msarett@google.com

[msarett, 2016-04-04 20:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1834303003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-04 20:42:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834303003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834303003/20001

[commit-bot: I haz the power, 2016-04-04 20:53:04]

Description was changed from

==========
Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f
==========

[commit-bot: I haz the power, 2016-04-04 20:53:06]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f

[mtklein, 2016-04-04 21:57:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1853383002/ by mtklein@google.com.

The reason for reverting is: Used by Chrome.

c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53):
error C2039: 'GetFlattenableType': is not a member of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\third_party\skia\include\core\skshader.h(19):
note: see declaration of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53):
error C3861: 'GetFlattenableType': identifier not found
.

[reed1, 2016-04-04 21:57:56]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[msarett, 2016-04-05 16:39:02]

Description was changed from

==========
Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f
==========

to

==========
Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f
==========

[msarett, 2016-04-05 16:39:53]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 16:39:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834303003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834303003/40001

[commit-bot: I haz the power, 2016-04-05 16:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 16:53:49]

Dry run: This issue passed the CQ dry run.