Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1860943002: [interpreter] Rely on SharedFunctionInfo in UseIgnition. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
rmcilroy, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Rely on SharedFunctionInfo in UseIgnition. This makes sure the SharedFunctionInfo is available whenever we evaluate the UseIgnition predicate. This makes sure we can apply filters properly even when the interpreter causes eager compilation (instead of lazy). R=rmcilroy@chromium.org Committed: https://crrev.com/0ce296f1808062a5f995855d2cd90612aec0ebd1 Cr-Commit-Position: refs/heads/master@{#35263}

Patch Set 1 #

Patch Set 2 : Enable tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/compiler.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 2 chunks +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-05 12:24:03 UTC) #1
rmcilroy
Nice, LGTM, thanks.
4 years, 8 months ago (2016-04-05 13:00:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860943002/20001
4 years, 8 months ago (2016-04-05 13:04:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13223)
4 years, 8 months ago (2016-04-05 13:08:31 UTC) #6
rossberg
lgtm
4 years, 8 months ago (2016-04-05 14:03:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860943002/20001
4 years, 8 months ago (2016-04-05 14:05:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 14:07:21 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0ce296f1808062a5f995855d2cd90612aec0ebd1 Cr-Commit-Position: refs/heads/master@{#35263}
4 years, 8 months ago (2016-04-05 14:08:07 UTC) #13
Michael Achenbach
On 2016/04/05 14:08:07, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 8 months ago (2016-04-05 18:29:17 UTC) #14
Michael Hablich
4 years, 8 months ago (2016-04-05 21:34:14 UTC) #15
Message was sent while issue was closed.
On 2016/04/05 18:29:17, Michael Achenbach wrote:
> On 2016/04/05 14:08:07, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/0ce296f1808062a5f995855d2cd90612aec0ebd1
> > Cr-Commit-Position: refs/heads/master@{#35263}
> 
> Please skip some tests for ignition + msan that time out after this CL:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20...

Blocking the roll. Skip CL: https://codereview.chromium.org/1865683002

Powered by Google App Engine
This is Rietveld 408576698