Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issue 1857203002: [compiler] Ensure feedback vector before compiling. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-internal-7
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Ensure feedback vector before compiling. This makes sure the type feedback vector is allocated and installed on the SharedFunctionInfo before any of the compilers are being called. Note that this now allows for an object state where a function is not compiled but has a valid feedback vector is installed. This is working as intended and supported by the rest of the system. R=mvstanton@chromium.org Committed: https://crrev.com/b527ec119fda8fd872b94d6dae613265308c8e00 Cr-Commit-Position: refs/heads/master@{#35265}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -38 lines) Patch
M src/compiler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler.cc View 7 chunks +23 lines, -30 lines 1 comment Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
https://codereview.chromium.org/1857203002/diff/1/src/compiler.cc File src/compiler.cc (left): https://codereview.chromium.org/1857203002/diff/1/src/compiler.cc#oldcode1501 src/compiler.cc:1501: if (info.has_shared_info()) { This is genuinely dead code. Drive-by ...
4 years, 8 months ago (2016-04-05 12:55:43 UTC) #1
mvstanton
great! lgtm.
4 years, 8 months ago (2016-04-05 13:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857203002/1
4 years, 8 months ago (2016-04-05 14:13:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 14:30:04 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 14:30:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b527ec119fda8fd872b94d6dae613265308c8e00
Cr-Commit-Position: refs/heads/master@{#35265}

Powered by Google App Engine
This is Rietveld 408576698