Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1860933002: Handle null values when constructing a native AutofillProfile from an Android one. (Closed)

Created:
4 years, 8 months ago by Bernhard Bauer
Modified:
4 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle null values when constructing a native AutofillProfile from an Android one. BUG=600677 Committed: https://crrev.com/08543664b073ae4fdabedde0d3414366e87417bc Cr-Commit-Position: refs/heads/master@{#385191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +38 lines, -38 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bernhard Bauer
Please review. From what I understand, an Android AutofillProfile can legitimately contain null values (if ...
4 years, 8 months ago (2016-04-05 11:12:28 UTC) #2
Evan Stade
Is this a recent regression? Lgtm I guess but I haven't worked on autofill in ...
4 years, 8 months ago (2016-04-05 16:17:23 UTC) #3
Bernhard Bauer
On 2016/04/05 16:17:23, Evan Stade wrote: > Is this a recent regression? Lgtm I guess ...
4 years, 8 months ago (2016-04-05 16:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860933002/1
4 years, 8 months ago (2016-04-05 16:26:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 16:36:31 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 16:37:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08543664b073ae4fdabedde0d3414366e87417bc
Cr-Commit-Position: refs/heads/master@{#385191}

Powered by Google App Engine
This is Rietveld 408576698