Handle null values when constructing a native AutofillProfile from an Android one.

chrome/browser/autofill/android/personal_data_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
 
 #include <stddef.h>
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
@@ skipping 55 matching lines @@
       ConvertUTF16ToJavaString(
           env, profile.GetRawInfo(ADDRESS_HOME_SORTING_CODE)).obj(),
       ConvertUTF16ToJavaString(
           env, profile.GetRawInfo(ADDRESS_HOME_COUNTRY)).obj(),
       ConvertUTF16ToJavaString(
           env, profile.GetRawInfo(PHONE_HOME_WHOLE_NUMBER)).obj(),
       ConvertUTF16ToJavaString(env, profile.GetRawInfo(EMAIL_ADDRESS)).obj(),
       ConvertUTF8ToJavaString(env, profile.language_code()).obj());
 }
 
+void MaybeSetRawInfo(AutofillProfile* profile,
+                     autofill::ServerFieldType type,
+                     const base::android::JavaRef<jstring>& jstr) {
+  if (!jstr.is_null())
+    profile->SetRawInfo(type, ConvertJavaStringToUTF16(jstr));
+}
+
 void PopulateNativeProfileFromJava(
-    const jobject& jprofile,
+    const JavaParamRef<jobject>& jprofile,
     JNIEnv* env,
     AutofillProfile* profile) {
   profile->set_origin(
       ConvertJavaStringToUTF8(
-          Java_AutofillProfile_getOrigin(env, jprofile)));
-  profile->SetInfo(
-      AutofillType(NAME_FULL),
-      ConvertJavaStringToUTF16(Java_AutofillProfile_getFullName(env, jprofile)),
-      g_browser_process->GetApplicationLocale());
-  profile->SetRawInfo(autofill::COMPANY_NAME,
-                      ConvertJavaStringToUTF16(
-                          Java_AutofillProfile_getCompanyName(env, jprofile)));
-  profile->SetRawInfo(
-      autofill::ADDRESS_HOME_STREET_ADDRESS,
-      ConvertJavaStringToUTF16(
-          Java_AutofillProfile_getStreetAddress(env, jprofile)));
-  profile->SetRawInfo(
-      autofill::ADDRESS_HOME_STATE,
-      ConvertJavaStringToUTF16(Java_AutofillProfile_getRegion(env, jprofile)));
-  profile->SetRawInfo(autofill::ADDRESS_HOME_CITY,
-                      ConvertJavaStringToUTF16(
-                          Java_AutofillProfile_getLocality(env, jprofile)));
-  profile->SetRawInfo(
-      autofill::ADDRESS_HOME_DEPENDENT_LOCALITY,
-      ConvertJavaStringToUTF16(
-          Java_AutofillProfile_getDependentLocality(env, jprofile)));
-  profile->SetRawInfo(autofill::ADDRESS_HOME_ZIP,
-                      ConvertJavaStringToUTF16(
-                          Java_AutofillProfile_getPostalCode(env, jprofile)));
-  profile->SetRawInfo(autofill::ADDRESS_HOME_SORTING_CODE,
-                      ConvertJavaStringToUTF16(
-                          Java_AutofillProfile_getSortingCode(env, jprofile)));
-  profile->SetInfo(AutofillType(ADDRESS_HOME_COUNTRY),
+          Java_AutofillProfile_getOrigin(env, jprofile.obj())));
+  profile->SetInfo(AutofillType(NAME_FULL),
                    ConvertJavaStringToUTF16(
-                       Java_AutofillProfile_getCountryCode(env, jprofile)),
+                       Java_AutofillProfile_getFullName(env, jprofile.obj())),
                    g_browser_process->GetApplicationLocale());
-  profile->SetRawInfo(autofill::PHONE_HOME_WHOLE_NUMBER,
-                      ConvertJavaStringToUTF16(
-                          Java_AutofillProfile_getPhoneNumber(env, jprofile)));
-  profile->SetRawInfo(autofill::EMAIL_ADDRESS,
-                      ConvertJavaStringToUTF16(
-                          Java_AutofillProfile_getEmailAddress(env, jprofile)));
+  MaybeSetRawInfo(profile, autofill::COMPANY_NAME,
+                  Java_AutofillProfile_getCompanyName(env, jprofile.obj()));
+  MaybeSetRawInfo(profile, autofill::ADDRESS_HOME_STREET_ADDRESS,
+                  Java_AutofillProfile_getStreetAddress(env, jprofile.obj()));
+  MaybeSetRawInfo(profile, autofill::ADDRESS_HOME_STATE,
+                  Java_AutofillProfile_getRegion(env, jprofile.obj()));
+  MaybeSetRawInfo(profile, autofill::ADDRESS_HOME_CITY,
+                  Java_AutofillProfile_getLocality(env, jprofile.obj()));
+  MaybeSetRawInfo(
+      profile, autofill::ADDRESS_HOME_DEPENDENT_LOCALITY,
+      Java_AutofillProfile_getDependentLocality(env, jprofile.obj()));
+  MaybeSetRawInfo(profile, autofill::ADDRESS_HOME_ZIP,
+                  Java_AutofillProfile_getPostalCode(env, jprofile.obj()));
+  MaybeSetRawInfo(profile, autofill::ADDRESS_HOME_SORTING_CODE,
+                  Java_AutofillProfile_getSortingCode(env, jprofile.obj()));
+  ScopedJavaLocalRef<jstring> country_code =
+      Java_AutofillProfile_getCountryCode(env, jprofile.obj());
+  if (!country_code.is_null()) {
+    profile->SetInfo(AutofillType(ADDRESS_HOME_COUNTRY),
+                     ConvertJavaStringToUTF16(country_code),
+                     g_browser_process->GetApplicationLocale());
+  }
+  MaybeSetRawInfo(profile, autofill::PHONE_HOME_WHOLE_NUMBER,
+                  Java_AutofillProfile_getPhoneNumber(env, jprofile.obj()));
+  MaybeSetRawInfo(profile, autofill::EMAIL_ADDRESS,
+                  Java_AutofillProfile_getEmailAddress(env, jprofile.obj()));
   profile->set_language_code(
       ConvertJavaStringToUTF8(
-          Java_AutofillProfile_getLanguageCode(env, jprofile)));
+          Java_AutofillProfile_getLanguageCode(env, jprofile.obj())));
 }
 
 ScopedJavaLocalRef<jobject> CreateJavaCreditCardFromNative(
     JNIEnv* env,
     const CreditCard& card) {
   return Java_CreditCard_create(
       env, ConvertUTF8ToJavaString(env, card.guid()).obj(),
       ConvertUTF8ToJavaString(env, card.origin()).obj(),
       card.record_type() == CreditCard::LOCAL_CARD,
       card.record_type() == CreditCard::FULL_SERVER_CARD,
@@ skipping 225 matching lines @@
                base::android::ConvertJavaStringToUTF16(env, jcountry_name)));
 }
 
 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   PersonalDataManagerAndroid* personal_data_manager_android =
       new PersonalDataManagerAndroid(env, obj);
   return reinterpret_cast<intptr_t>(personal_data_manager_android);
 }
 
 }  // namespace autofill