Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860833002: Propogate types from arguments to parameters early during inlining. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Propogate types from arguments to parameters early during inlining. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/27c1a6c9009b708245eb2a0e7709996ed5143965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M runtime/vm/flow_graph_inliner.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
http://146.148.43.81:8080/Comparison#targetA%3Ddart-unopt%3BmachineTypeA%3Dlinux-armv7hf%3BrevisionA%3D51666%3BpatchA%3Drmacnak-parameter-inlining%3BtargetB%3Ddart-unopt%3BmachineTypeB%3Dlinux-armv7hf%3BrevisionB%3D51666%3BpatchB%3DNone
4 years, 8 months ago (2016-04-04 23:59:52 UTC) #4
Florian Schneider
lgtm
4 years, 8 months ago (2016-04-05 00:06:54 UTC) #5
rmacnak
4 years, 8 months ago (2016-04-05 21:46:29 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
27c1a6c9009b708245eb2a0e7709996ed5143965 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698