Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 1860833002: Propogate types from arguments to parameters early during inlining. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_inliner.cc
diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc
index 9ee6365a49ef934c08e2d520cb0434d7fffb6d8a..d164ddf2c2539be965b1abfb83cc7cd515c60798 100644
--- a/runtime/vm/flow_graph_inliner.cc
+++ b/runtime/vm/flow_graph_inliner.cc
@@ -609,7 +609,9 @@ class CallSiteInliner : public ValueObject {
if (constant != NULL) {
return new(Z) ConstantInstr(constant->value());
} else {
- return new(Z) ParameterInstr(i, graph->graph_entry());
+ ParameterInstr* param = new(Z) ParameterInstr(i, graph->graph_entry());
+ param->UpdateType(*argument->Type());
+ return param;
}
}
@@ -832,6 +834,13 @@ class CallSiteInliner : public ValueObject {
DEBUG_ASSERT(callee_graph->VerifyUseLists());
} else {
JitOptimizer optimizer(callee_graph);
+
+ optimizer.ApplyClassIds();
+ DEBUG_ASSERT(callee_graph->VerifyUseLists());
+
+ FlowGraphTypePropagator::Propagate(callee_graph);
+ DEBUG_ASSERT(callee_graph->VerifyUseLists());
+
optimizer.ApplyICData();
DEBUG_ASSERT(callee_graph->VerifyUseLists());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698