Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on gl_renderer

Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on gl_renderer

For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741
TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fecf94b1e7ce2e6ab0e89a0a7aefd1a1771f94c1
Cr-Commit-Position: refs/heads/master@{#390310}

[Julien Isorce Samsung, 2016-04-06 12:16:52]

Description was changed from

==========
Fix not selected workaround when relying on gl_renderer on win os.

Add DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also factor testing code in common with DriverBugWorkaroundsInGpuProcessPage.

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process

Add DriverBugWorkaroundsInGpuProcessPage to gpu_process_test.py

This test ensure that the fake "use_gpu_driver_workaround_for_testing" is
present in both Browser process (GpuDataManager) and GPU process (FeatureInfo).

This new test would have catch the regression fixed by CL
https://codereview.chromium.org/1415603009.

BUG=554909

R=kbr@chromium.org, zmo@chromium.org, jbauman@chromium.org,
ccameron@chromium.org, piman@chromium.org, dcheng@chromium.org,
palmer@chromium.org

TEST=./content/test/gpu/run_gpu_test.py driver_bug_workarounds_in_gpu_process

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

patch from issue 1463823002 at patchset 300001
(http://crrev.com/1463823002#ps300001)
==========

to

==========
Fix not selected workarounds that rely on gl_renderer on win os.

Add DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also factor python code in common with DriverBugWorkaroundsInGpuProcessPage and
move it to new base class DriverBugWorkaroundsTestsPage.

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Julien Isorce Samsung, 2016-04-06 23:58:57]

I just added more explanation on
https://bugs.chromium.org/p/chromium/issues/detail?id=600741

[Julien Isorce Samsung, 2016-04-26 23:59:19]

Description was changed from

==========
Fix not selected workarounds that rely on gl_renderer on win os.

Add DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also factor python code in common with DriverBugWorkaroundsInGpuProcessPage and
move it to new base class DriverBugWorkaroundsTestsPage.

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on
gl_renderer
    
For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Julien Isorce Samsung, 2016-04-27 00:02:36]

On 2016/04/06 23:58:57, j.isorce wrote:
> I just added more explanation on
> https://bugs.chromium.org/p/chromium/issues/detail?id=600741

Hi Zhenyao, please have a look to this CL. Thx

[Zhenyao Mo, 2016-04-27 00:15:26]

On 2016/04/27 00:02:36, j.isorce wrote:
> On 2016/04/06 23:58:57, j.isorce wrote:
> > I just added more explanation on
> > https://bugs.chromium.org/p/chromium/issues/detail?id=600741
> 
> Hi Zhenyao, please have a look to this CL. Thx

LGTM

[Zhenyao Mo, 2016-04-27 00:15:43]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 00:16:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860823004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860823004/40001

[Zhenyao Mo, 2016-04-27 00:16:35]

zmo@chromium.org changed reviewers:
+ jmadill@chromium.org

[commit-bot: I haz the power, 2016-04-27 01:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 01:24:05]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-04-27 10:07:01]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 10:07:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860823004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860823004/60001

[commit-bot: I haz the power, 2016-04-27 11:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 11:34:48]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-04-27 11:52:13]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-04-27 11:52:14]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1860823004/#ps60001
(title: "Just rebase")

[commit-bot: I haz the power, 2016-04-27 11:52:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860823004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860823004/60001

[commit-bot: I haz the power, 2016-04-27 12:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 12:01:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julien Isorce Samsung, 2016-04-27 12:05:24]

On 2016/04/27 12:01:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/gpu/gpu_main.cc
    content/public/common/content_switches.cc
    content/public/common/content_switches.h

Hi Antoine, please have a look to this CL, thx.

[piman, 2016-04-27 22:14:05]

1 thing, otherwise LGTM

https://codereview.chromium.org/1860823004/diff/60001/content/gpu/gpu_main.cc
File content/gpu/gpu_main.cc (right):

https://codereview.chromium.org/1860823004/diff/60001/content/gpu/gpu_main.cc...
content/gpu/gpu_main.cc:310: defined(OS_WIN)
We're in the !(OS_MACOSX), I don't think there's anything left - maybe just
remove the ifdef altogether?

[Julien Isorce Samsung, 2016-04-27 23:02:50]

https://codereview.chromium.org/1860823004/diff/60001/content/gpu/gpu_main.cc
File content/gpu/gpu_main.cc (right):

https://codereview.chromium.org/1860823004/diff/60001/content/gpu/gpu_main.cc...
content/gpu/gpu_main.cc:310: defined(OS_WIN)
On 2016/04/27 22:14:05, piman wrote:
> We're in the !(OS_MACOSX), I don't think there's anything left - maybe just
> remove the ifdef altogether?

Good point I think you are right. Since the next function is about applying gpu
driver workarounds then upon your remark I took the following as reference:

GpuControlList::OsType GpuControlList::GetOsType() {
#if defined(OS_CHROMEOS)
  return kOsChromeOS;
#elif defined(OS_WIN)
  return kOsWin;
#elif defined(OS_ANDROID)
  return kOsAndroid;
#elif defined(OS_LINUX) || defined(OS_OPENBSD)
  return kOsLinux;
#elif defined(OS_MACOSX)
  return kOsMacosx;
#else
  return kOsUnknown;
#endif
}

Since OS_LINUX and OS_OPENBSD are handled with the same enum I guess previously
it was missing OS_OPENBSD in the #ifdef that this CL modifies.
So I did what you suggested in Patch Set 5. Thx!

[Julien Isorce Samsung, 2016-04-27 23:03:19]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 23:03:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860823004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860823004/80001

[piman, 2016-04-27 23:04:44]

lgtm

[commit-bot: I haz the power, 2016-04-28 00:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 00:46:00]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-04-28 05:47:50]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-04-28 05:47:51]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1860823004/#ps80001
(title: "Remove the ifdef altogether and rebase")

[commit-bot: I haz the power, 2016-04-28 05:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860823004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860823004/80001

[commit-bot: I haz the power, 2016-04-28 05:52:27]

Description was changed from

==========
Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on
gl_renderer
    
For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on
gl_renderer
    
For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-28 05:52:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:16:29]

Patchset 5 (id:??) landed as
https://crrev.com/fecf94b1e7ce2e6ab0e89a0a7aefd1a1771f94c1
Cr-Commit-Position: refs/heads/master@{#390310}

[commit-bot: I haz the power, 2016-04-30 17:54:23]

Description was changed from

==========
Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on
gl_renderer
    
For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on
gl_renderer

For example the current entry id 51 from kGpuDriverBugListJson,
is never selected on Windows because gpu::ApplyGpuDriverBugWorkarounds
(from gpu_main.cc) is currently not called on Windows.
It is only called on chromeos, android and linux. On osx no problem since
no entry id relies on gl_renderer.

This CL also adds DriverBugWorkaroundsUponGLRendererPage to gpu_process_test.py

Also this CL adds a new base class DriverBugWorkaroundsTestsPage to factor
some common code.

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

BUG=600741

TEST=./content/test/gpu/run_gpu_test.py gpu_process
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fecf94b1e7ce2e6ab0e89a0a7aefd1a1771f94c1
Cr-Commit-Position: refs/heads/master@{#390310}
==========