Entries from kGpuDriverBugListJson are not selected on OS_WIN when relying on gl_renderer

content/gpu/gpu_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdlib.h>
 
 #include <memory>
 #include <utility>
 
@@ skipping 288 matching lines @@
       // crash.
       // By skipping the following code on Mac, we don't really lose anything,
       // because the basic GPU information is passed down from browser process
       // and we already registered them through SetGpuInfo() above.
       base::TimeTicks before_collect_context_graphics_info =
           base::TimeTicks::Now();
 #if !defined(OS_MACOSX)
       if (!CollectGraphicsInfo(gpu_info))
         dead_on_arrival = true;
 
-#if defined(OS_CHROMEOS) || defined(OS_ANDROID) || defined(OS_LINUX)
+#if defined(OS_CHROMEOS) || defined(OS_ANDROID) || defined(OS_LINUX) || \
+    defined(OS_WIN)

[piman, 2016/04/27 22:14:05]

We're in the !(OS_MACOSX), I don't think there's anything left - maybe just
remove the ifdef altogether?

[Julien Isorce Samsung, 2016/04/27 23:02:50]

Good point I think you are right. Since the next function is about applying gpu
driver workarounds then upon your remark I took the following as reference:

GpuControlList::OsType GpuControlList::GetOsType() {
#if defined(OS_CHROMEOS)
  return kOsChromeOS;
#elif defined(OS_WIN)
  return kOsWin;
#elif defined(OS_ANDROID)
  return kOsAndroid;
#elif defined(OS_LINUX) || defined(OS_OPENBSD)
  return kOsLinux;
#elif defined(OS_MACOSX)
  return kOsMacosx;
#else
  return kOsUnknown;
#endif
}

Since OS_LINUX and OS_OPENBSD are handled with the same enum I guess previously
it was missing OS_OPENBSD in the #ifdef that this CL modifies.
So I did what you suggested in Patch Set 5. Thx!

       // Recompute gpu driver bug workarounds.
       // This is necessary on systems where vendor_id/device_id aren't available
       // (Chrome OS, Android) or where workarounds may be dependent on GL_VENDOR
       // and GL_RENDERER strings which are lazily computed (Linux).
       if (!command_line.HasSwitch(switches::kDisableGpuDriverBugWorkarounds)) {
         // TODO: this can not affect disabled extensions, since they're already
         // initialized in the bindings. This should be moved before bindings
         // initialization. However, populating GPUInfo fully works only on
         // Android. Other platforms would need the bindings to query GL strings.
         gpu::ApplyGpuDriverBugWorkarounds(
@@ skipping 111 matching lines @@
       &gpu_info.gpu.vendor_id);
   DCHECK(success);
   success = base::HexStringToUInt(
       command_line.GetSwitchValueASCII(switches::kGpuDeviceID),
       &gpu_info.gpu.device_id);
   DCHECK(success);
   gpu_info.driver_vendor =
       command_line.GetSwitchValueASCII(switches::kGpuDriverVendor);
   gpu_info.driver_version =
       command_line.GetSwitchValueASCII(switches::kGpuDriverVersion);
+  gpu_info.driver_date =
+      command_line.GetSwitchValueASCII(switches::kGpuDriverDate);
   gpu::ParseSecondaryGpuDevicesFromCommandLine(command_line, &gpu_info);
 
   // Set active gpu device.
   if (command_line.HasSwitch(switches::kGpuActiveVendorID) &&
       command_line.HasSwitch(switches::kGpuActiveDeviceID)) {
     uint32_t active_vendor_id = 0;
     uint32_t active_device_id = 0;
     success = base::HexStringToUInt(
         command_line.GetSwitchValueASCII(switches::kGpuActiveVendorID),
         &active_vendor_id);
@@ skipping 159 matching lines @@
     return true;
   }
 
   return false;
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace.
 
 }  // namespace content