Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860783004: Make the saved password website link-able. (Closed)

Created:
4 years, 8 months ago by hcarmona
Modified:
4 years, 8 months ago
Reviewers:
stevenjb, Devlin
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-password-observer.gitbr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the saved password website link-able. BUG=595538 Committed: https://crrev.com/01169ce8869769a57004aa8acf0177e560dc930a Cr-Commit-Position: refs/heads/master@{#387494}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/passwords_private.idl View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/passwords_private.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
hcarmona
PTAL, I'm adding the link-able URL to the passwords section to get feature parity w/ ...
4 years, 8 months ago (2016-04-04 22:46:07 UTC) #2
stevenjb
lgtm
4 years, 8 months ago (2016-04-06 00:08:53 UTC) #3
hcarmona
+rdevlin.cronin for OWNER on chrome/common/extensions/api/passwords_private.idl
4 years, 8 months ago (2016-04-06 00:15:23 UTC) #5
Devlin
lgtm https://codereview.chromium.org/1860783004/diff/1/third_party/closure_compiler/externs/passwords_private.js File third_party/closure_compiler/externs/passwords_private.js (right): https://codereview.chromium.org/1860783004/diff/1/third_party/closure_compiler/externs/passwords_private.js#newcode1 third_party/closure_compiler/externs/passwords_private.js:1: // Copyright 2016 The Chromium Authors. All rights ...
4 years, 8 months ago (2016-04-06 00:19:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860783004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860783004/20001
4 years, 8 months ago (2016-04-15 00:39:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 00:45:00 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 00:47:30 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/01169ce8869769a57004aa8acf0177e560dc930a
Cr-Commit-Position: refs/heads/master@{#387494}

Powered by Google App Engine
This is Rietveld 408576698