Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2697)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 1860783004: Make the saved password website link-able. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-password-observer.gitbr
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index 2626e429c143873495e1fd6cb3cad5637596102c..83e679a9a91ead80605e50996e69db184e18875d 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -79,6 +79,15 @@
-webkit-margin-start: 56px;
margin-bottom: 16px;
}
+
+ .list-link {
+ color: black;
+ text-decoration: none;
+ }
+
+ .list-link:hover {
+ text-decoration: underline;
+ }
</style>
<!-- TODO(hcarmona): i18n this string and link -->
<div id="manageLink">Access your passwords from any device at
@@ -96,8 +105,8 @@
items="[[savedPasswords]]">
<template>
<div class="list-item">
- <div id="originUrl"
- class="website-column">[[item.loginPair.originUrl]]</div>
+ <a id="originUrl" href="[[item.linkUrl]]" target="_blank"
+ class="website-column list-link">[[item.loginPair.originUrl]]</a>
<div id="username"
class="username-column">[[item.loginPair.username]]</div>
<div class="password-column">

Powered by Google App Engine
This is Rietveld 408576698