Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1860753005: Support all possible bitflags when computing the PSL DAFSA (Closed)

Created:
4 years, 8 months ago by Ryan Sleevi
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Support all possible bitflags when computing the PSL DAFSA make_dafsa.py restricted the set of flags a given eTLD could have to being the discrete values (0, 1, 2, 4), but the underlying implementation is as a bitmask. Support the entire range of valid values within make_dafsa, so that non-ICANN eTLDs can have wildcards or exceptions BUG=591253 Review URL: https://codereview.chromium.org/1756733003 Cr-Commit-Position: refs/heads/master@{#379167} (cherry picked from commit 55859a4ac6f8d43c63752ddcba20c6df76710e1f) Committed: https://chromium.googlesource.com/chromium/src/+/fbc95014262c9b56a79859a3ef79309d19246173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M net/tools/dafsa/make_dafsa.py View 1 chunk +4 lines, -4 lines 0 comments Download
M net/tools/dafsa/make_dafsa_unittest.py View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ryan Sleevi
4 years, 8 months ago (2016-04-04 23:27:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fbc95014262c9b56a79859a3ef79309d19246173.

Powered by Google App Engine
This is Rietveld 408576698