Support all possible bitflags when computing the PSL DAFSA

Support all possible bitflags when computing the PSL DAFSA

make_dafsa.py restricted the set of flags a given eTLD could have to
being the discrete values (0, 1, 2, 4), but the underlying
implementation is as a bitmask. Support the entire range of valid
values within make_dafsa, so that non-ICANN eTLDs can have wildcards or
exceptions

BUG=591253
Committed: https://crrev.com/55859a4ac6f8d43c63752ddcba20c6df76710e1f
Cr-Commit-Position: refs/heads/master@{#379167}

[Ryan Sleevi, 2016-03-02 22:48:34]

rsleevi@chromium.org changed reviewers:
+ pkasting@chromium.org

[Ryan Sleevi, 2016-03-02 22:48:34]

Peter: Please take a look. Hopefully should be self-explanatory. There's tests!
:D

[Ryan Sleevi, 2016-03-02 23:21:47]

On 2016/03/02 22:48:34, Ryan Sleevi wrote:
> Peter: Please take a look. Hopefully should be self-explanatory. There's
tests!
> :D

To make it easier to review:
https://code.google.com/p/chromium/codesearch#chromium/src/net/tools/tld_clea...
https://code.google.com/p/chromium/codesearch#chromium/src/net/base/registry_...

This is the code that handles it as masks

[Peter Kasting, 2016-03-03 20:41:54]

Unfortunately I'm the wrong reviewer for this; I don't speak Python and I don't
know what this tool does to boot.

That said, this is clearly a small, simple change.  LGTM for OWNERS; up to you
to the degree you want to get a real review on this.

[Ryan Sleevi, 2016-03-03 21:10:03]

rsleevi@chromium.org changed reviewers:
+ maruel@chromium.org

[Ryan Sleevi, 2016-03-03 21:10:03]

maruel did the original Python review, and I did the review (for Opera) of the
logic... so I'll ask Marc-Antoine to check the Python, and trust in faith (...
and tests) for the logic.

[M-A Ruel, 2016-03-03 22:19:43]

lgtm with nit

https://codereview.chromium.org/1756733003/diff/1/net/tools/dafsa/make_dafsa.py
File net/tools/dafsa/make_dafsa.py (right):

https://codereview.chromium.org/1756733003/diff/1/net/tools/dafsa/make_dafsa....
net/tools/dafsa/make_dafsa.py:453: if line[-1] not in map(str, range(0, 7)):
That's an relatively expensive call to do at every single line. Replace the line
with:
if line.endswith(('0', '1', '2', '3', '4', '5', '6', '7')):

[Ryan Sleevi, 2016-03-04 00:15:59]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-03-04 00:15:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1756733003/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-03-04 00:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756733003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756733003/20001

[commit-bot: I haz the power, 2016-03-04 01:35:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 01:36:36]

Description was changed from

==========
Support all possible bitflags when computing the PSL DAFSA

make_dafsa.py restricted the set of flags a given eTLD could have to
being the discrete values (0, 1, 2, 4), but the underlying
implementation is as a bitmask. Support the entire range of valid
values within make_dafsa, so that non-ICANN eTLDs can have wildcards or
exceptions

BUG=591253
==========

to

==========
Support all possible bitflags when computing the PSL DAFSA

make_dafsa.py restricted the set of flags a given eTLD could have to
being the discrete values (0, 1, 2, 4), but the underlying
implementation is as a bitmask. Support the entire range of valid
values within make_dafsa, so that non-ICANN eTLDs can have wildcards or
exceptions

BUG=591253

Committed: https://crrev.com/55859a4ac6f8d43c63752ddcba20c6df76710e1f
Cr-Commit-Position: refs/heads/master@{#379167}
==========

[commit-bot: I haz the power, 2016-03-04 01:36:37]

Patchset 2 (id:??) landed as
https://crrev.com/55859a4ac6f8d43c63752ddcba20c6df76710e1f
Cr-Commit-Position: refs/heads/master@{#379167}