Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858893002: Remove WebBindings. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebBindings. BUG=493212 R=piman@chromium.org Committed: https://crrev.com/2d5af72ce42f2f5deb5b138aad0a516dbcf49bf2 Cr-Commit-Position: refs/heads/master@{#385086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -249 lines) Patch
D third_party/WebKit/Source/web/WebBindings.cpp View 1 chunk +0 lines, -136 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/web/WebBindings.h View 1 chunk +0 lines, -111 lines 0 comments Download

Dependent Patchsets:

Issue 1860753002 Patch 20001
Issue 1860753002 Patch 40001
Issue 1860753002 Patch 60001

Messages

Total messages: 8 (2 generated)
dcheng
Whee.
4 years, 8 months ago (2016-04-04 22:44:53 UTC) #1
piman
Oh, lgtm. I also had it here - https://codereview.chromium.org/1860753002/# , but your CL likely will ...
4 years, 8 months ago (2016-04-04 22:52:32 UTC) #2
dcheng
Ah, I didn't see that: I was basically just waiting for //content/child/npapi to go away. ...
4 years, 8 months ago (2016-04-04 23:12:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858893002/1
4 years, 8 months ago (2016-04-04 23:13:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 02:16:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 02:19:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2d5af72ce42f2f5deb5b138aad0a516dbcf49bf2
Cr-Commit-Position: refs/heads/master@{#385086}

Powered by Google App Engine
This is Rietveld 408576698