Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3773)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 1860743002: Add a flag to change when android's progress bar completes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded variables on ProgressTracker Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
index bb41b481944a616d00982eb6fce612e8429f5d0c..e2e9a633b5618640f7ee0dc33ed5c446acb3ebec 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
@@ -317,6 +317,8 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
int statusCode) {
if (isNavigationToDifferentPage) {
mToolbar.onNavigatedToDifferentPage();
+ mToolbar.startLoadProgress();
+ updateLoadProgress(tab.getProgress());
mdjones 2016/06/20 20:58:40 If I'm not mistaken, this should always happen aft
Nate Chapin 2016/06/21 21:06:28 I think there may have been a bug fix between when
}
}
@@ -1149,6 +1151,7 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
progress = Math.max(progress, MINIMUM_LOAD_PROGRESS);
mToolbar.setLoadProgress(progress / 100f);
+ if (progress == 100) finishLoadProgress(true);
mdjones 2016/06/20 20:58:41 Can updateLoadProgress hit 100 without triggering
Nate Chapin 2016/06/21 21:06:28 On trunk, no, 100 is only triggered as part of onL
}
private void finishLoadProgress(boolean delayed) {
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698