Add a flag to change when android's progress bar completes

chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.toolbar;
 
 import android.content.Context;
 import android.content.res.Configuration;
 import android.graphics.drawable.Drawable;
 import android.os.Handler;
@@ skipping 299 matching lines @@
             public void onWebContentsInstantSupportDisabled() {
                 mLocationBar.setUrlToPageUrl();
             }
 
             @Override
             public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,
                     boolean isNavigationToDifferentPage, boolean isFragmentNavigation,
                     int statusCode) {
                 if (isNavigationToDifferentPage) {
                     mToolbar.onNavigatedToDifferentPage();
+                    mToolbar.startLoadProgress();
+                    updateLoadProgress(tab.getProgress());

[mdjones, 2016/06/20 20:58:40]

If I'm not mistaken, this should always happen after
onDidStartProvisionalLoadForFrame. Did something change where this wouldn't be
the case?

[Nate Chapin, 2016/06/21 21:06:28]

I think there may have been a bug fix between when I originally made this change
and now. I can't reproduce the "progress bar never reappears" issue I was
having. Dropped this change.

                 }
             }
 
             @Override
             public void onTitleUpdated(Tab tab) {
                 mLocationBar.setTitleToPageTitle();
             }
 
             @Override
             public void onUrlUpdated(Tab tab) {
@@ skipping 812 matching lines @@
     private void updateLoadProgress(int progress) {
         // If it's a native page, progress bar is already hidden or being hidden, so don't update
         // the value.
         // TODO(kkimlabs): Investigate back/forward navigation with native page & web content and
         //                 figure out the correct progress bar presentation.
         Tab tab = mToolbarModel.getTab();
         if (NativePageFactory.isNativePageUrl(tab.getUrl(), tab.isIncognito())) return;
 
         progress = Math.max(progress, MINIMUM_LOAD_PROGRESS);
         mToolbar.setLoadProgress(progress / 100f);
+        if (progress == 100) finishLoadProgress(true);

[mdjones, 2016/06/20 20:58:41]

Can updateLoadProgress hit 100 without triggering onLoadStopped?

[Nate Chapin, 2016/06/21 21:06:28]

On trunk, no, 100 is only triggered as part of onLoadStopped. With this change,
the experimental flags allow the progress bar to complete before onLoadStopped.
onLoadStopped will still be called eventually, but there could easily be a delay
of several seconds between the progress bar completing and onLoadStopped..

     }
 
     private void finishLoadProgress(boolean delayed) {
         mLoadProgressSimulator.cancel();
         mToolbar.finishLoadProgress(delayed);
     }
 
     /**
      * Only start showing the progress bar if it is not already started.
      */
@@ skipping 56 matching lines @@
         }
 
         /**
          * Cancels simulating load progress.
          */
         public void cancel() {
             mHandler.removeMessages(MSG_ID_UPDATE_PROGRESS);
         }
     }
 }