Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1860693005: Revert of Delete SkFlattenable::Type (part 1) (Closed)

Created:
4 years, 8 months ago by msarett
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Delete SkFlattenable::Type (part 1) (patchset #1 id:1 of https://codereview.chromium.org/1861013002/ ) Reason for revert: See sugoi's comment. Original issue's description: > Delete SkFlattenable::Type (part 1) > > This should allow me to delete uses of SkFlattenable::Type in Chrome. > Then I'll follow up with the full delete. > https://codereview.chromium.org/1834303003/ > > TBR=reed@google.com > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002 > > Committed: https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce TBR=reed@google.com,mtklein@google.com,sugoi@chromium.org,senorblanco@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/be243d4737bb5601984e1d1c4e72e2a6c0788edf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M include/core/SkFlattenableSerialization.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Delete SkFlattenable::Type (part 1)
4 years, 8 months ago (2016-04-05 19:00:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860693005/1
4 years, 8 months ago (2016-04-05 19:00:45 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 19:00:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/be243d4737bb5601984e1d1c4e72e2a6c0788edf

Powered by Google App Engine
This is Rietveld 408576698